Update ReplaceText to use MovePage
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	abi_
	Jun 13 2019, 6:14 PM

Description

We're using ReplaceText extension on Translatewiki.net.

When renaming / moving titles we get the following warning,

PHP Deprecated:  Use of Title::isValidMoveOperation was deprecated in MediaWiki 1.25. [Called from SpecialReplaceText::getTitlesForMoveAndUnmoveableTitles in /srv/mediawiki/tags/2019-06-10_15:00:00/extensions/ReplaceText/src/SpecialReplaceText.php at line 348] in /srv/mediawiki/tags/2019-06-10_15:00:00/includes/debug/MWDebug.php on line 309

PHP Deprecated:  Use of Title::moveTo was deprecated in MediaWiki 1.25. [Called from ReplaceTextJob::run in /srv/mediawiki/tags/2019-06-10_15:00:00/extensions/ReplaceText/src/ReplaceTextJob.php at line 69] in /srv/mediawiki/tags/2019-06-10_15:00:00/includes/debug/MWDebug.php on line 309

The code should be updated to use the MovePage class.

Details

	Subject	Repo	Branch	Lines +/-
	Replace usage of Title class move methods with MovePage class methods	mediawiki/extensions/ReplaceText	master	+21 -11

Customize query in gerrit

Related Objects

Duplicates Merged Here: T230255: PHP Deprecated: Use of Title::isValidMoveOperation was deprecated in MediaWiki 1.25

Event Timeline

abi_ created this task.Jun 13 2019, 6:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 13 2019, 6:14 PM

abi_ added a parent task: T41480: [DO NOT USE] Issues affecting translatewiki.net [superseded by #affects-translatewiki.net].Jul 16 2019, 8:26 AM

Pginer-WMF added a project: Language-Team (Language-2019-July-September).Jul 24 2019, 7:52 AM

Pginer-WMF moved this task from Backlog to Priority backlog on the Language-Team (Language-2019-July-September) board.

Pginer-WMF triaged this task as Medium priority.Jul 24 2019, 7:58 AM

Change 525307 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/ReplaceText@master] Replace usage of Title class move methods with MovePage class methods

https://gerrit.wikimedia.org/r/525307

gerritbot added a project: Patch-For-Review.Jul 24 2019, 3:36 PM

• Petar.petkovic assigned this task to abi_.Jul 24 2019, 6:47 PM

• Petar.petkovic moved this task from Priority backlog to In Review on the Language-Team (Language-2019-July-September) board.

Thanks for updating this Petar. Still a work in progress though.

abi_ moved this task from In Progress to In Review on the Language-Team (Language-2019-July-September) board.Jul 25 2019, 6:46 AM

Raymond merged a task: T230255: PHP Deprecated: Use of Title::isValidMoveOperation was deprecated in MediaWiki 1.25.Aug 10 2019, 10:02 PM

Raymond subscribed.

Change 525307 merged by jenkins-bot:
[mediawiki/extensions/ReplaceText@master] Replace usage of Title class move methods with MovePage class methods

https://gerrit.wikimedia.org/r/525307

Maintenance_bot removed a project: Patch-For-Review.Aug 21 2019, 8:10 AM

• Petar.petkovic moved this task from In Review to Needs QA on the Language-Team (Language-2019-July-September) board.Aug 21 2019, 10:58 AM

This has been deployed to translatewiki.net.