Maniphest T225888

Add page title to no-JS confirmation page
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	stjn
	Jun 16 2019, 3:43 PM

Tags

Referenced Files

None

Subscribers

Description

Currently, no-JS confirmation page has no page title. That causes an empty <h1> element to appear and tab title to display something like — Wikipedia.

I think you should add page title where rollback is happening to the title of confirmation page, like it is done for ?action=purge. Or something else at your discretion.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	REL1_36	+2 -0	RollbackAction: fix missing pagetitle
	mediawiki/core	REL1_35	+2 -0	RollbackAction: fix missing pagetitle
	mediawiki/core	REL1_37	+2 -0	RollbackAction: fix missing pagetitle
	mediawiki/core	master	+2 -0	RollbackAction: fix missing pagetitle

Customize query in gerrit

Event Timeline

stjn created this task.Jun 16 2019, 3:43 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 16 2019, 3:43 PM

To test this, you need $wgDefaultUserOptions['showrollbackconfirmation'] = 1; and disable your Javascript.

Change 743604 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/core@master] RollbackAction: fix missing pagetitle

https://gerrit.wikimedia.org/r/743604

gerritbot added a project: Patch-For-Review.Dec 4 2021, 10:13 PM

TheDJ claimed this task.Dec 4 2021, 10:13 PM

TheDJ triaged this task as Low priority.

Change 743604 merged by jenkins-bot:

[mediawiki/core@master] RollbackAction: fix missing pagetitle

https://gerrit.wikimedia.org/r/743604

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Dec 4 2021, 11:00 PM

TheDJ closed this task as Resolved.Dec 4 2021, 11:08 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 4 2021, 11:10 PM

Change 745881 had a related patch set uploaded (by Legoktm; author: TheDJ):

[mediawiki/core@REL1_37] RollbackAction: fix missing pagetitle

https://gerrit.wikimedia.org/r/745881

gerritbot added a project: Patch-For-Review.Dec 13 2021, 2:20 AM

Change 746030 had a related patch set uploaded (by Legoktm; author: TheDJ):

[mediawiki/core@REL1_36] RollbackAction: fix missing pagetitle

https://gerrit.wikimedia.org/r/746030

Change 746031 had a related patch set uploaded (by Legoktm; author: TheDJ):

[mediawiki/core@REL1_35] RollbackAction: fix missing pagetitle

https://gerrit.wikimedia.org/r/746031

Change 745881 merged by jenkins-bot:

[mediawiki/core@REL1_37] RollbackAction: fix missing pagetitle

https://gerrit.wikimedia.org/r/745881

Change 746031 merged by jenkins-bot:

[mediawiki/core@REL1_35] RollbackAction: fix missing pagetitle

https://gerrit.wikimedia.org/r/746031

Change 746030 merged by jenkins-bot:

[mediawiki/core@REL1_36] RollbackAction: fix missing pagetitle

https://gerrit.wikimedia.org/r/746030

ReleaseTaggerBot added projects: MW-1.37-notes, MW-1.36-notes, MW-1.35-notes.Dec 13 2021, 3:00 AM