Fix emails for status 4
Closed, ResolvedPublic
Actions

Edit Task
Edit Related Tasks...
Create Subtask
Edit Parent Tasks
Edit Subtasks
Merge Duplicates In
Close As Duplicate
Edit Related Objects...
Edit Commits
Edit Mocks
Mute Notifications
Protect as security issue
Award Token
Flag For Later

Assigned To

Authored By

	Samwalton9-WMF
	Jun 17 2019, 9:57 AM

Description

Setting applications to status type 4 (Sent?) is causing our email tasks to error:

Traceback:  

File "/app/TWLight/emails/tasks.py" in update_app_status_on_save
  352.             handlers[handler_key](instance)

Exception Type: KeyError
Exception Value: 4

Event Timeline

Samwalton9-WMF created this task.Jun 17 2019, 9:57 AM

Restricted Application added subscribers: Sadads, Aklapper. · View Herald TranscriptJun 17 2019, 9:57 AM

Looks like this code was written before we had a wider range of statuses.

Fixed in https://github.com/WikipediaLibrary/TWLight/pull/276

Samwalton9-WMF closed this task as Resolved.Jun 26 2019, 2:00 PM

Samwalton9-WMF triaged this task as Medium priority.

Fix emails for status 4Closed, ResolvedPublicActions

Description

Event Timeline

Fix emails for status 4
Closed, ResolvedPublic
Actions