Page MenuHomePhabricator
Create Task
Maniphest T225930

Implement Link Counter
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Acceptance Criteria:

  • identify the links according to the requirements documented on T224832
  • show the number of links on the page

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Wikibasemaster+63 -27bridge: make init js testable
mediawiki/extensions/Wikibasemaster+51 -22bridge: Make linkcounter somewhat testable
mediawiki/extensions/Wikibasemaster+8 -0Implement basic link counter
mediawiki/extensions/Wikibasemaster+33 -0bridge: Implement basic link counter in typescript
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT225937 Implement Bridge Setup
 ResolvedMichaelT225930 Implement Link Counter
 ResolvedMichaelT226010 Add bridge init js via ResourceLoader
 ResolvedMichaelT225935 Implement Feature Flag for Mediawiki

Event Timeline

darthmon_wmde created this task.Jun 17 2019, 12:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 17 2019, 12:22 PM
darthmon_wmde edited projects, added Wikidata, Wikidata-Bridge-Sprint-0; removed Wikidata-Bridge.Jun 17 2019, 12:22 PM
darthmon_wmde updated the task description. (Show Details)
darthmon_wmde updated the task description. (Show Details)
darthmon_wmde edited projects, added Wikidata-Bridge; removed Wikidata-Bridge-Sprint-0.
darthmon_wmde set the point value for this task to 5.Jun 17 2019, 12:28 PM
darthmon_wmde moved this task from Ready to estimate to Ready to pick up on the Wikidata-Bridge board.
darthmon_wmde added a parent task: T225937: Implement Bridge Setup.Jun 17 2019, 1:21 PM
• Pablo-WMDE edited projects, added Wikidata-Bridge-Sprint-0; removed Wikidata-Bridge.Jun 18 2019, 11:22 AM
gerritbot added a comment.Jun 18 2019, 2:21 PM

Change 517659 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Implement basic link counter

https://gerrit.wikimedia.org/r/517659

gerritbot added a project: Patch-For-Review.Jun 18 2019, 2:21 PM
gerritbot added a comment.Jun 21 2019, 1:05 PM

Change 518255 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] bridge: Implement basic link counter in typescript

https://gerrit.wikimedia.org/r/518255

Michael moved this task from To do to Doing on the Wikidata-Bridge-Sprint-0 board.Jun 21 2019, 1:19 PM
• Addshore moved this task from incoming to in progress on the Wikidata board.Jun 21 2019, 11:23 PM
gerritbot added a comment.Jun 24 2019, 11:15 AM

Change 518678 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] bridge: Make linkcounter somewhat testable

https://gerrit.wikimedia.org/r/518678

gerritbot added a comment.Jun 24 2019, 12:06 PM

Change 518255 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Implement basic link counter in typescript

https://gerrit.wikimedia.org/r/518255

gerritbot added a comment.Jun 24 2019, 1:39 PM

Change 517659 abandoned by Michael Große:
Implement basic link counter

Reason:
superseded by Ia0ab4326db

https://gerrit.wikimedia.org/r/517659

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.11; 2019-06-26).Jun 24 2019, 2:00 PM
gerritbot added a comment.Jun 25 2019, 10:43 AM

Change 518678 abandoned by Michael Große:
bridge: Make linkcounter somewhat testable

Reason:
we decided to go with Ie8bd0798b3c26a0022d309e6498706452346bb49

https://gerrit.wikimedia.org/r/518678

Michael claimed this task.Jun 25 2019, 11:02 AM
Michael moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-0 board.
Restricted Application added a project: User-Michael. · View Herald TranscriptJun 25 2019, 11:02 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 25 2019, 11:10 AM
Michael moved this task from Peer Review to Doing on the Wikidata-Bridge-Sprint-0 board.Jun 25 2019, 11:17 AM
gerritbot added a comment.Jun 25 2019, 12:08 PM

Change 518711 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] bridge: make init js testable

https://gerrit.wikimedia.org/r/518711

gerritbot added a project: Patch-For-Review.Jun 25 2019, 12:08 PM
Michael moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-0 board.Jun 25 2019, 12:08 PM
• Matthias_Geisler_WMDE moved this task from Peer Review to Doing on the Wikidata-Bridge-Sprint-0 board.Jun 25 2019, 12:33 PM
Michael moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-0 board.Jun 25 2019, 2:44 PM
gerritbot added a comment.Jun 27 2019, 12:34 PM

Change 518711 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: make init js testable

https://gerrit.wikimedia.org/r/518711

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.13; 2019-07-09); removed MW-1.34-notes (1.34.0-wmf.11; 2019-06-26).Jun 27 2019, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 27 2019, 1:10 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Verification on the Wikidata-Bridge-Sprint-0 board.Jun 28 2019, 10:17 AM
Michael closed subtask T226010: Add bridge init js via ResourceLoader as Resolved.Jun 28 2019, 10:43 AM
Michael mentioned this in T226010: Add bridge init js via ResourceLoader.
Lucas_Werkmeister_WMDE added subscribers: Lydia_Pintscher, Lucas_Werkmeister_WMDE.Jun 28 2019, 10:50 AM

For now, you can test this on the beta cluster by running mw.loader.using( 'wikibase.client.data-bridge.init' ) in the web console. (With T226816: Enable data bridge on Wikidata Beta, that will no longer be necessary.) On this test page, the following message should get logged:

Number of links potentially usable for data bridge: 3

(Once T226494: Create configuration for matching regex is implemented and the corresponding config deployed, that number should change to 2.)

Lucas_Werkmeister_WMDE added a comment.Jun 28 2019, 7:12 PM

(With T226609: Create rudimentary bridge app and export via ResourceLoader deployed, you will now only see a “hello world” text without the number of links.)

• Pablo-WMDE moved this task from Verification to Done on the Wikidata-Bridge-Sprint-0 board.Jul 3 2019, 9:12 AM
• Pablo-WMDE closed this task as Resolved.Jul 3 2019, 9:26 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL