oathauth-ui-error-page-no-module need refining
Closed, ResolvedPublic
Actions

Description

If I swap module=top for module=lol, I get given (oathauth-ui-error-page-no-module) - No Two-factor authentication method is currently enabled.

This isn't true, there are some enabled; totp is enabled, but lol isn't

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/OATHAuth	master	+0 -2	Remove unused message keys
	mediawiki/extensions/OATHAuth	master	+0 -2	Remove orphaned oathauth-ui-error-page-no-module message

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Reedy	T227242 Deploy WebAuthn to Wikimedia Wikis
Resolved	ItSpiderman	T100373 WebAuthn (U2F) integration for Extension:OATHAuth
Resolved	ItSpiderman	T218214 SO878 Step 3: Finalize settings and user experience
Resolved	CCicalese_WMF	T226058 oathauth-ui-error-page-no-module need refining

Event Timeline

Reedy created this task.Jun 18 2019, 10:01 PM

Reedy edited parent tasks, added: T218214: SO878 Step 3: Finalize settings and user experience; removed: T218210: SO878 Step 1: Refactor OATHAuth extension.Jul 4 2019, 6:56 PM

WDoranWMF moved this task from Contractor - Doing to S&F Workboard on the Platform Team Workboards board.Jul 5 2019, 4:53 PM

WDoranWMF edited projects, added Platform Team Workboards (S&F Workboard); removed Platform Team Workboards (Contractor - Doing).

WDoranWMF moved this task from Backlog to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.

Reedy moved this task from Backlog to User Experience on the MediaWiki-extensions-OathAuth board.Jul 5 2019, 9:57 PM

CCicalese_WMF edited projects, added Platform Team Initiatives (Two-Factor Authentication (TEC1)); removed Platform Engineering (Needs Cleaning - Security, stability, performance, and scalability (TEC1)).Jul 27 2019, 4:13 PM

Is this issue still relevant? This message key is actually not used anymore, as error SpecialPage is gone now. I could not reproduce the issue

In T226058#5379371, @ItSpiderman wrote:

Is this issue still relevant? This message key is actually not used anymore, as error SpecialPage is gone now. I could not reproduce the issue

If this is the case, we should remove it from the en.json/qqq.json so translators are not translating it unnecessarily

In T226058#5379371, @ItSpiderman wrote:

Is this issue still relevant? This message key is actually not used anymore, as error SpecialPage is gone now. I could not reproduce the issue

If I visit Special:Manage_Two-factor_authentication&action=disable&module=foobar it just basically displays Special:Manage_Two-factor_authentication

So I will accept that it's been fixed as part of the refactoring etc

The message should definitely be removed though

Change 526667 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/OATHAuth@master] Remove orphaned oathauth-ui-error-page-no-module message

https://gerrit.wikimedia.org/r/526667

gerritbot added a project: Patch-For-Review.Jul 31 2019, 1:29 PM

Reedy mentioned this in T229415: Remove any orphaned i18n messages.Jul 31 2019, 1:31 PM

Change 526677 had a related patch set uploaded (by ItSpiderman; owner: ItSpiderman):
[mediawiki/extensions/OATHAuth@master] Remove unused message keys

https://gerrit.wikimedia.org/r/526677

Change 526667 merged by jenkins-bot:
[mediawiki/extensions/OATHAuth@master] Remove orphaned oathauth-ui-error-page-no-module message

https://gerrit.wikimedia.org/r/526667

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.17; 2019-08-06).Jul 31 2019, 4:01 PM

Change 526677 abandoned by ItSpiderman:
Remove unused message keys

https://gerrit.wikimedia.org/r/526677

CCicalese_WMF closed this task as Resolved.Jul 31 2019, 4:41 PM

CCicalese_WMF claimed this task.

Maintenance_bot removed a project: Patch-For-Review.Jul 31 2019, 5:11 PM

CCicalese_WMF moved this task from In Progress/Doing to Done on the Platform Team Workboards (S&F Workboard) board.Aug 30 2019, 8:59 PM