Page MenuHomePhabricator

oathauth/step2 and oathauth-step2alt layout and information
Closed, ResolvedPublic

Description

Screenshot 2019-06-18 at 23.05.07.png (592×292 px, 33 KB)

oathauth-step2alt doesn't seem to be in the right place... The secret is after the account name... So this feels a bit odd. Semantics

Also, some "hint" of the sitename (to be used as a prefix ie $wgOATHAuthAccountPrefix) might be useful to list to the users

			'manual' => [
				'type' => 'info',
				'label-message' => 'oathauth-step2alt',
				'default' =>
					'<strong>' . $this->msg( 'oathauth-account' )->escaped() . '</strong><br/>'
					. htmlspecialchars( $this->oathUser->getAccount() ) . '<br/><br/>'
					. '<strong>' . $this->msg( 'oathauth-secret' )->escaped() . '</strong><br/>'
					. '<kbd>' . $this->getSecretForDisplay( $key ) . '</kbd><br/>',
				'raw' => true,
				'section' => 'step2',
			],

Event Timeline

Change 985935 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] TOTPEnableForm: Display issuer in manual account name

https://gerrit.wikimedia.org/r/985935

Change 985936 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] TOTPEnableForm: Reorder manual step and improve oathauth-step2alt

https://gerrit.wikimedia.org/r/985936

Change 985935 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] TOTPEnableForm: Display issuer in manual account name

https://gerrit.wikimedia.org/r/985935

Change 985936 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] TOTPEnableForm: Reorder manual step and improve oathauth-step2alt

https://gerrit.wikimedia.org/r/985936

Change 985405 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@REL1_41] TOTPEnableForm: Display issuer in manual account name

https://gerrit.wikimedia.org/r/985405

Change 986206 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@REL1_40] TOTPEnableForm: Display issuer in manual account name

https://gerrit.wikimedia.org/r/986206

Change 986207 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@REL1_39] TOTPEnableForm: Display issuer in manual account name

https://gerrit.wikimedia.org/r/986207

Change 986207 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@REL1_39] TOTPEnableForm: Display issuer in manual account name

https://gerrit.wikimedia.org/r/986207

Change 985405 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@REL1_41] TOTPEnableForm: Display issuer in manual account name

https://gerrit.wikimedia.org/r/985405

Change 986206 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@REL1_40] TOTPEnableForm: Display issuer in manual account name

https://gerrit.wikimedia.org/r/986206

Change 986208 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@REL1_41] TOTPEnableForm: Reorder manual step and improve oathauth-step2alt

https://gerrit.wikimedia.org/r/986208

Change 986209 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@REL1_40] TOTPEnableForm: Reorder manual step and improve oathauth-step2alt

https://gerrit.wikimedia.org/r/986209

Change 986210 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@REL1_39] TOTPEnableForm: Reorder manual step and improve oathauth-step2alt

https://gerrit.wikimedia.org/r/986210

Change 986210 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@REL1_39] TOTPEnableForm: Reorder manual step and improve oathauth-step2alt

https://gerrit.wikimedia.org/r/986210

Change 986208 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@REL1_41] TOTPEnableForm: Reorder manual step and improve oathauth-step2alt

https://gerrit.wikimedia.org/r/986208

Change 986209 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@REL1_40] TOTPEnableForm: Reorder manual step and improve oathauth-step2alt

https://gerrit.wikimedia.org/r/986209

Reedy claimed this task.