Page MenuHomePhabricator

Empty depicts statements display 'unsupported datatype' message
Closed, ResolvedPublic

Description

We have this:

With other statements, we changed the "unsupported statement" message you get when you attempt to edit - it is now only shown for properties whose datatype we don't support yet.
However, 'depicts' gets added to the page automatically - without value.
The code that currently detects what is supported, uses the statement (in this case: no value) to determine whether the datatype is supported.
Because it has no value, it figures this is not a supported datatype, and grays out the depicts widget and shows a warning when attempting to edit.

We want this:

Nothing - "depicts" is supported

Acceptance criteria:

Can be tested on https://commons.wikimedia.beta.wmflabs.org/wiki/File:VisualEditor_toolbar_actions-fur.png

  • (if there are no existing 'depicts' statements) the depicts widgets must not be grayed out
  • (if there are no existing 'depicts' statements) when clicking 'edit' in depicts widget, one must not get an "Unsupported property" popup

QA Results

ACStatusDetails
1T226096#5293515
2T226096#5293515

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 517840 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Also support properties with *no* value

https://gerrit.wikimedia.org/r/517840

Change 517840 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Also support properties with *no* value

https://gerrit.wikimedia.org/r/517840

Edtadros added subscribers: Ramsey-WMF, Edtadros.

Test Result

Status: ❓ Need more info
OS: macOS Mojave
Browser: Chrome
Device: MBP

Test Artifact(s):===Acceptance criteria:

Can be tested on https://commons.wikimedia.beta.wmflabs.org/wiki/File:VisualEditor_toolbar_actions-fur.png

❓ AC1: (if there are no existing 'depicts' statements) the depicts widgets must not be grayed out

Screen Shot 2019-06-28 at 5.38.42 PM.png (388×1 px, 56 KB)

@Ramsey-WMF, I'm not entirely sure what the "depicts widget" encompases on the page. I didn't see anything disabled but I thought I'd make sure.

✅ AC2: (if there are no existing 'depicts' statements) when clicking 'edit' in depicts widget, one must not get an "Unsupported property" popup

T226096.gif (1×1 px, 397 KB)

No problems on production.