ImageListPager.php: Call to a member function getUrl() on a non-object (boolean)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

[XQowzwpAAEAAAHjy0MEAAABU] 2019-06-19 12:55:44: 嚴重例外類型 "BadMethodCallException"

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix wfLocalFile() replacement	mediawiki/core	wmf/1.34.0-wmf.10	+1 -1
	Fix wfLocalFile() replacement	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	• mmodell	T220735 1.34.0-wmf.10 deployment blockers
		Resolved	PRODUCTION ERROR	Lucas_Werkmeister_WMDE	T226102 BadMethodCallException on Commons: /includes/specials/pagers/ImageListPager.php: Call to a member function getUrl() on a non-object (boolean)

Event Timeline

Xiplus created this task.Jun 19 2019, 1:11 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 19 2019, 1:11 PM

@A2093064 Can you briefly describe what you were trying to do when this error happened?

I can see it in the logs, but I don't want to describe it publicly without your permission.

@Krinkle A user posted this error message in a Facebook group. He said he can't upload files and view Special:ListFiles/His_name. These are all I know. Maybe I can ask him for his permission.

He moved "File:蔣培火墓.jpg" to "File:蔡培火墓.jpg" and got errors, then this file lost.

Now I view https://commons.wikimedia.org/wiki/Special:ListFiles/Pbdragonwang and got:

[XQpBhgpAMEoAAKmzvyEAAACH] 2019-06-19 14:07:02: Fatal exception of type "BadMethodCallException"

Taiwania_Justo added a project: Commons.Jun 19 2019, 2:36 PM

Taiwania_Justo subscribed.

Krinkle added a project: Multimedia.Jun 19 2019, 3:00 PM

Krinkle added a parent task: T220735: 1.34.0-wmf.10 deployment blockers.

Krinkle moved this task from Untriaged to Jun 2019 / 1.34.wmf.8+ on the Wikimedia-production-error board.

Train blockers are UBN.

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptJun 19 2019, 3:15 PM

Aklapper renamed this task from BadMethodCallException on commons to BadMethodCallException on Commons: /includes/specials/pagers/ImageListPager.php: Call to a member function getUrl() on a non-object (boolean).Jun 19 2019, 3:19 PM

Aklapper added a project: MediaWiki-Special-pages.

This patch made a change to /includes/specials/pagers/ImageListPager.php on a line that calls getUrl() https://gerrit.wikimedia.org/r/c/mediawiki/core/+/510199

CC'ing patch author and reviewer

RhinosF1 subscribed.Jun 19 2019, 6:37 PM

In T226102#5268918, @Cparle wrote:

This patch made a change to /includes/specials/pagers/ImageListPager.php on a line that calls getUrl() https://gerrit.wikimedia.org/r/c/mediawiki/core/+/510199

[In ImageListPager.php](https://gerrit.wikimedia.org/r/c/mediawiki/core/+/510199/20/includes/specials/pagers/ImageListPager.php#b471), it replaced wfLocalFile() with $services->getRepoGroup()->findFile(), but I think that’s actually the replacement for wfFindFile(), and the correct replacement for wfLocalFile() would be $services->getRepoGroup()->getLocalRepo()->newFile(). I should’ve checked this more thoroughly in review, sorry. I’ll upload a patch.

Change 517999 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/core@master] Fix wfLocalFile() replacement

https://gerrit.wikimedia.org/r/517999

gerritbot added a project: Patch-For-Review.Jun 20 2019, 10:01 AM

Unfortunately I can’t reproduce the bug locally, so I’m not sure if the fix works. Is it okay if I temporarily apply it on mwdebug1002 before it’s merged, or is that frowned upon?

Oh nevermind, I can’t test it on mwdebug1002 either with the train being rolled back.

Change 517999 merged by jenkins-bot:
[mediawiki/core@master] Fix wfLocalFile() replacement

https://gerrit.wikimedia.org/r/517999

Maintenance_bot removed a project: Patch-For-Review.Jun 20 2019, 11:10 AM

Change 518013 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/core@wmf/1.34.0-wmf.10] Fix wfLocalFile() replacement

https://gerrit.wikimedia.org/r/518013

gerritbot added a project: Patch-For-Review.Jun 20 2019, 11:14 AM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.11; 2019-06-26).Jun 20 2019, 12:00 PM

So this is provisionally fixed but we can't tell until the train rolls forward to Commons, is that right?

I think yes, @Jdforrester-WMF.

Change 518013 merged by jenkins-bot:
[mediawiki/core@wmf/1.34.0-wmf.10] Fix wfLocalFile() replacement

https://gerrit.wikimedia.org/r/518013

Maintenance_bot removed a project: Patch-For-Review.Jun 20 2019, 4:10 PM

Mentioned in SAL (#wikimedia-operations) [2019-06-20T16:19:08Z] <krinkle@deploy1001> Synchronized php-1.34.0-wmf.10/includes/specials/pagers/ImageListPager.php: T226102 / rMW294500d6e1d7 (duration: 00m 58s)