Three clicks required to exit talk overlay
Closed, ResolvedPublicSpike
Actions

Assigned To

Authored By

	kostajh
	Jun 19 2019, 2:23 PM

Description

Steps to reproduce:

Visit https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=TemplateUsageArticle587
Tap "Discussion"
Tap "Add discussion"
Add a subject and comment press "Publish"
The URL ends in #/talk
Tap the X or press the browser back button
The URL now ends in #/talk/
Tap the X or press the browser back button
The URL now ends in #/talk
Tap the X or press the browser back button
You have exited the overlay :)

Acceptance criteria for research:

assess the complexity of this issue

A: not complex

propose possible solutions

A: obvious solution

QA steps

Follow reproduction steps on beta cluster and confirm they no longer apply.

QA Results

AC	Status	Details
1	✅	T226106#5343882
2	✅	T226106#5343882

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	router.navigate is deprecated use router.navigateTo	mediawiki/skins/MinervaNeue	master	+4 -2

Customize query in gerrit

Related Objects

Mentioned In: T228418: Mobile talk overlay not updating with new threads
rSKIN267b7f5db953: Update git submodules
T228235: Edits lost when clicking back from talk overlay
Mentioned Here: T217102: MFA: TalkSectionAddOverlay should use Overlay.make pattern

Event Timeline

kostajh created this task.Jun 19 2019, 2:23 PM

kostajh triaged this task as High priority.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 19 2019, 2:23 PM

Jdrewniak added a project: Web-Team-Backlog-Archived.Jun 19 2019, 4:10 PM

phuedx moved this task from Needs triage to MinervaNeue on the Mobile board.Jun 20 2019, 10:06 AM

I can reproduce that

ovasileva moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog-Archived board.Jun 26 2019, 5:16 PM

• nray claimed this task.Jun 26 2019, 5:18 PM

I'm pretty sure I fixed this in T217102 but the patch became a quite large refactor and we were a little scared of proceeding.

Patches were https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/493624/ and https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/493742/ (note reference in first one about history)

ovasileva renamed this task from Three clicks required to exit talk overlay to [Research 4hrs] Three clicks required to exit talk overlay.Jul 2 2019, 4:45 PM

ovasileva updated the task description. (Show Details)

ovasileva edited projects, added Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q4); removed Web-Team-Backlog-Archived.

• nray removed • nray as the assignee of this task.Jul 3 2019, 3:45 PM

• nray subscribed.

MBinder_WMF edited projects, added Web-Team-Backlog-Archived (Readers-Web-Kanbanana-2019-20-Q1); removed Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q4).Jul 3 2019, 5:42 PM

MBinder_WMF changed the subtype of this task from "Task" to "Spike".Jul 9 2019, 5:11 PM

There's a glaring bug here that when addressed fixes the problem...

Change 523828 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] router.navigate is deprecated use router.navigateTo

https://gerrit.wikimedia.org/r/523828

gerritbot added a project: Patch-For-Review.Jul 16 2019, 11:21 PM

Jdlrobson mentioned this in T228235: Edits lost when clicking back from talk overlay.Jul 16 2019, 11:34 PM

Change 523828 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] router.navigate is deprecated use router.navigateTo

https://gerrit.wikimedia.org/r/523828

Maintenance_bot removed a project: Patch-For-Review.Jul 17 2019, 3:10 PM

Restricted Repository Identity mentioned this in rSKIN267b7f5db953: Update git submodules.Jul 17 2019, 3:11 PM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.15; 2019-07-23).Jul 17 2019, 4:01 PM

Jdlrobson renamed this task from [Research 4hrs] Three clicks required to exit talk overlay to Three clicks required to exit talk overlay.Jul 17 2019, 4:07 PM

Jdlrobson reassigned this task from Jdlrobson to Edtadros.

Jdlrobson moved this task from Needs Code Review to Needs QA on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-2019-20-Q1) board.

Jdlrobson updated the task description. (Show Details)

ovasileva renamed this task from Three clicks required to exit talk overlay to [Research 4hrs] Three clicks required to exit talk overlay.Jul 17 2019, 4:41 PM

Jdlrobson renamed this task from [Research 4hrs] Three clicks required to exit talk overlay to Three clicks required to exit talk overlay.Jul 17 2019, 5:08 PM

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

QA Steps

Visit https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=TemplateUsageArticle587
Tap "Discussion"
Tap "Add discussion"
Add a subject and comment press "Publish"
✅ AC1: The URL ends in #/talk

AMC ON	AMC OFF

Tap the X or press the browser back button
✅ AC2: The overlay is exited

AMC ON	AMC OFF

Edtadros updated the task description. (Show Details)Jul 18 2019, 12:19 AM

Jdrewniak mentioned this in T228418: Mobile talk overlay not updating with new threads.Jul 18 2019, 12:24 PM

ovasileva closed this task as Resolved.Jul 18 2019, 3:17 PM

	F29796255: Screen Shot 2019-07-17 at 5.09.26 PM.png
	Jul 18 2019, 12:17 AM

	F29796354: Screen Shot 2019-07-17 at 5.16.10 PM.png
	Jul 18 2019, 12:17 AM

	F29796278: Screen Shot 2019-07-17 at 5.11.12 PM.png
	Jul 18 2019, 12:17 AM

	F29796364: Screen Shot 2019-07-17 at 5.16.41 PM.png
	Jul 18 2019, 12:17 AM

Three clicks required to exit talk overlayClosed, ResolvedPublicSpikeActions