Change the color of Alert/Message indicator.
Open, MediumPublic
Actions

Assigned To

None

Authored By

	Shivanshbindal9
	Jun 19 2019, 9:25 PM

Description

If all the notifications are read or there are no notifications at start, then the polling starts and there is some new notification, the alert/messages indicator does not change color. This is because the alert widget is instantiated on page load and the hasUnseen property never gets updated.

Details

	Subject	Repo	Branch	Lines +/-
	Use utility functions to improve code readability	mediawiki/extensions/Echo	master	+6 -5
	Add unseen class to alert/message icons	mediawiki/extensions/Echo	master	+44 -12

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		None	T14884 Login and account creation should be by secure http.
Invalid		None	T11816 Improve security for Special:Userlogin (tracking)
Invalid		Wikinaut	T3932 [DO NOT USE] ENotif/EConfirm & further enhancements (tracking) [superseded by #MediaWiki-Email]
Open		None	T125653 Create new types of notifications
Open	Feature	None	T5234 Extend edit-user-talk notification to include edits to subpages of a user's talk page
Resolved		• demon	T11838 Send notification to account owner on multiple unsuccessful login attempts
Duplicate		None	T21248 Hotwatch: User_talk-style banner notifications for select article changes
Declined		Quiddity	T22541 Watchlist, LiquidThreads and Echo notifications need to be unified
Resolved		None	T29829 welcome users without relying on additions to talk page
Resolved		Galorefitz	T31856 Email notification to old address when verified email address is changed or removed
Declined		None	T13636 Allowing watchlist notifications if the watchlist is smaller than a certain size
Open	Feature	None	T31857 Welcome back email notification after renewed account activity
Resolved		kostajh	T34281 MediaWiki needs a sane notification system (tracking)
Open		None	T75209 The document title should be dynamically updated to include a (n) notifications count in the browser title bar.
Stalled		None	T116243 Offer system tray area desktop notifications
Open		None	T34284 Update Echo Notifications in real time without page reloads
Resolved		Shivanshbindal9	T219222 Make notification counts update without page reload
Open		None	T226127 Change the color of Alert/Message indicator.

Event Timeline

Shivanshbindal9 created this task.Jun 19 2019, 9:25 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 19 2019, 9:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Shivanshbindal9 triaged this task as Medium priority.Jun 19 2019, 9:25 PM

Shivanshbindal9 added a parent task: T219222: Make notification counts update without page reload.

Change 529591 had a related patch set uploaded (by Shivanshbindal9; owner: shivanshbindal9):
[mediawiki/extensions/Echo@master] Add unseen class to alert/message icons

https://gerrit.wikimedia.org/r/529591

gerritbot added a project: Patch-For-Review.Aug 11 2019, 10:09 AM

This is being worked on by a GSoC intern.

Change 529591 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Add unseen class to alert/message icons

https://gerrit.wikimedia.org/r/529591

Change 530637 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/Echo@master] Use utility functions to improve code readability

https://gerrit.wikimedia.org/r/530637

Change 530637 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Use utility functions to improve code readability

https://gerrit.wikimedia.org/r/530637

Maintenance_bot removed a project: Patch-For-Review.Aug 20 2019, 1:11 PM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Aug 20 2019, 9:01 PM

MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:51 PM