In one case, my clock icon was aligned at the bottom of its row, not in the middle. You can see that it started on my first article that I edited, and stayed misaligned even as a second row showed up with a correctly aligned icon.
Description
Details
Project | Branch | Lines +/- | Subject | |
---|---|---|---|---|
mediawiki/extensions/GrowthExperiments | master | +7 -3 | Impact: align pageviews numbers and icons |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | • Rileych | T213990 [EPIC] Growth: Newcomer homepage | |||
Resolved | MMiller_WMF | T215983 Homepage: mobile version | |||
Resolved | MMiller_WMF | T225676 Homepage: mobile MVP list | |||
Resolved | MMiller_WMF | T216217 Homepage: impact module | |||
Resolved | SBisson | T216220 Homepage: design for indicating that the user should check back for pageviews | |||
Resolved | MMiller_WMF | T226147 Homepage: impact clock icon issues on mobile |
Event Timeline
That's a focus outline and is an accessibility helper for keyboard users and an upstream issue of OOUI. The only workaround is not ready yet for production due to missing browser support T172578. My recommendation: decline.
Thanks @Volker_E for the clarification.
@MMiller_WMF about the icon's vertical alignment issue, it only happens (in both mobile and desktop) for rows with a real image because there is an issue with the image container's class.
To me the following fixes it (on both desktop and mobile):
.growthexperiments-homepage-module-impact .impact-row .article-image .real-image { background-position: center; display: inline-block; vertical-align: middle; }
But I would leave it to @SBisson @kostajh to decide what's the best way to approach it.
Thanks @Volker_E. I modified the issue description to only be about the vertical alignment of the icon.
Change 518265 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Impact: align pageviews numbers and icons
Change 518265 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Impact: align pageviews numbers and icons
Checked in betalabs - the alignment seems to be in place:
The Impact module on the Homepage shows 0 for the number of views that haven't been calculated yet. Is it intentional?
The Impact module on the Homepage shows 0 for the number of views that haven't been calculated yet. Is it intentional?
@Etonkovidova that will be addressed in T225560: Homepage: mobile preview when calculating