Page MenuHomePhabricator

Homepage: impact clock icon issues on mobile
Open, Needs TriagePublic

Description

In one case, my clock icon was aligned at the bottom of its row, not in the middle. You can see that it started on my first article that I edited, and stayed misaligned even as a second row showed up with a correctly aligned icon.

Event Timeline

@Cntlsn -- is this something we should fix?

MMiller_WMF renamed this task from Homepage: impact clock icon has outline on mobile to Homepage: impact clock icon issues on mobile.Jun 20 2019, 4:30 AM
MMiller_WMF updated the task description. (Show Details)

That's a focus outline and is an accessibility helper for keyboard users and an upstream issue of OOUI. The only workaround is not ready yet for production due to missing browser support T172578. My recommendation: decline.

phuedx moved this task from Needs triage to Triaged on the Mobile board.Jun 20 2019, 10:03 AM

@Volker_E Thanks for clarifying. This question comes up all the time.

Cntlsn added a comment.EditedJun 20 2019, 1:57 PM

Thanks @Volker_E for the clarification.

@MMiller_WMF about the icon's vertical alignment issue, it only happens (in both mobile and desktop) for rows with a real image because there is an issue with the image container's class.
To me the following fixes it (on both desktop and mobile):

.growthexperiments-homepage-module-impact .impact-row .article-image .real-image {
    background-position: center;
    display: inline-block;
    vertical-align: middle;
}

But I would leave it to @SBisson @kostajh to decide what's the best way to approach it.

MMiller_WMF updated the task description. (Show Details)Jun 20 2019, 9:26 PM

Thanks @Volker_E. I modified the issue description to only be about the vertical alignment of the icon.

This is ready for development.

Change 518265 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Impact: align pageviews numbers and icons

https://gerrit.wikimedia.org/r/518265

Cntlsn removed Cntlsn as the assignee of this task.Jun 25 2019, 12:18 PM
Cntlsn removed a project: Growth Design.

Change 518265 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Impact: align pageviews numbers and icons

https://gerrit.wikimedia.org/r/518265

Checked in betalabs - the alignment seems to be in place:

The Impact module on the Homepage shows 0 for the number of views that haven't been calculated yet. Is it intentional?

The Impact module on the Homepage shows 0 for the number of views that haven't been calculated yet. Is it intentional?

@Etonkovidova that will be addressed in T225560: Homepage: mobile preview when calculating

Looks good to me, moving to "Needs PM Review"

I'll resolve this once this looks good in production with next week's train.