Page MenuHomePhabricator

Remove `tabindex="1"` from #simpleSearch
Closed, ResolvedPublic

Description

With the accesskey assigned and the current tab flow, tabindex="1" seems like a relict of the past and also hindering “natural” keyboard flow.

tabindex="1" has originally been introduced to Vector as part of T48512 in https://gerrit.wikimedia.org/r/#/q/I87149d7e15931f02ab700164e9e1d3d707b5e6a5.
Current keyboard focus order seems completely confusing to me.

The general rule of thumb is

Avoid using tabindex values greater than 0. Doing so makes it difficult for people who rely on assistive technology to navigate and operate page content. Instead, write the document with the elements in a logical sequence.

This seems to apply here as well.

Details

Related Gerrit Patches:
mediawiki/skins/Vector : masterRemove unused 'jquery.tabIndex' dependency
mediawiki/skins/Vector : masterRemove `tabindex` attribute from search input

Event Timeline

Volker_E created this task.Jun 20 2019, 5:01 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 20 2019, 5:01 AM
Volker_E updated the task description. (Show Details)Sep 26 2019, 8:15 PM
Volker_E added subscribers: Jdlrobson, Krinkle, TheDJ, Nemo_bis.
Volker_E updated the task description. (Show Details)Sep 26 2019, 8:18 PM

Change 539413 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/Vector@master] Remove tabindex attribute from search input

https://gerrit.wikimedia.org/r/539413

Volker_E closed this task as Resolved.Sep 26 2019, 10:12 PM
Volker_E claimed this task.
Volker_E removed a project: Patch-For-Review.

Change 539413 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Remove tabindex attribute from search input

https://gerrit.wikimedia.org/r/539413

Is the dependency on jquery.tabIndex used anywhere else? If not, this can be removed, too.

Change 540733 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/skins/Vector@master] Remove unused 'jquery.tabIndex' dependency

https://gerrit.wikimedia.org/r/540733

Change 540733 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Remove unused 'jquery.tabIndex' dependency

https://gerrit.wikimedia.org/r/540733