Odd behaviour when editing qualifier property type but not value
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Cparle
	Jun 20 2019, 12:05 PM

Description

Acceptance criteria:

go to a File page that has a statement with qualifiers (e.g. https://commons.wikimedia.beta.wmflabs.org/wiki/File:Photo_on_20-06-2019_at_12.36.jpg)
click 'edit' on structured data panel showing the statement with its qualifiers
change one of the qualifiers so that its property has a different type (e.g. if the property has type entity change it to one with type quantity, or vice versa) - but don't change the value
click 'submit'
verify that the qualifier has been deleted (because it had no value)
verify that the statement panel can again be edited

QA Results

AC	Status	Details
1	✅	T226181#5348053
2	❌	T226181#5348053

Details

	Subject	Repo	Branch	Lines +/-
	Fix `data` handling	mediawiki/extensions/WikibaseMediaInfo	master	+11 -46
	Separate property & value formatting	mediawiki/extensions/WikibaseMediaInfo	master	+46 -47

Customize query in gerrit

Event Timeline

Cparle created this task.Jun 20 2019, 12:05 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 20 2019, 12:05 PM

matthiasmullie claimed this task.Jun 21 2019, 12:08 PM

Change 518243 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Separate property & value formatting

https://gerrit.wikimedia.org/r/518243

Change 518244 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Fix handling

https://gerrit.wikimedia.org/r/518244

matthiasmullie moved this task from To Do to Code Review on the Structured-Data-Team-Current-Work board.Jun 21 2019, 12:08 PM

• Ramsey-WMF triaged this task as Medium priority.Jun 25 2019, 3:03 PM

• Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.

• Ramsey-WMF added projects: Structured Data Engineering, SDC-Statements (Depicts-on-training-wheels).Jun 25 2019, 3:05 PM

• Ramsey-WMF moved this task from To Do to Doing on the Structured Data Engineering board.

Change 518243 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Separate property & value formatting

https://gerrit.wikimedia.org/r/518243

Change 518244 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Fix data handling

https://gerrit.wikimedia.org/r/518244

Maintenance_bot removed a project: Patch-For-Review.Jun 25 2019, 4:10 PM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.11; 2019-06-26).Jun 25 2019, 5:00 PM

Cparle moved this task from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.Jul 3 2019, 2:22 PM

matthiasmullie removed matthiasmullie as the assignee of this task.Jul 9 2019, 9:19 AM

matthiasmullie updated the task description. (Show Details)

matthiasmullie subscribed.

Cparle assigned this task to Edtadros.Jul 9 2019, 4:12 PM

Test Result

Status: ❌ FAIL
OS: macOS Mojave
Browser: Chrome
Device: MBP

Test Artifact(s):

QA Steps

go to a File page that has a statement with qualifiers (e.g. https://commons.wikimedia.beta.wmflabs.org/wiki/File:Photo_on_20-06-2019_at_12.36.jpg)
click 'edit' on structured data panel showing the statement with its qualifiers
change one of the qualifiers so that its property has a different type (e.g. if the property has type entity change it to one with type quantity, or vice versa) - but don't change the value
click 'submit'

✅ AC1: erify that the qualifier has been deleted (because it had no value)

❌ AC2: verify that the statement panel can again be edited

@matthiasmullie AC2 is partially satisfied, however at about 28 seconds into the video (I've attached an mp4 so that you can scroll to the 28 second mark) you see that the auto suggestion for qualifiers stops working. If the page is reloaded it will start working again.

T226181.mp42 MBDownload

Edtadros updated the task description. (Show Details)Jul 18 2019, 9:32 PM

Works as expected on production.

• Ramsey-WMF closed this task as Resolved.Jul 31 2019, 11:16 PM

	F29803774: T226181.gif
	Jul 18 2019, 9:32 PM

	F29803822: T226181.mp4
	Jul 18 2019, 9:32 PM

Odd behaviour when editing qualifier property type but not valueClosed, ResolvedPublicActions