Page MenuHomePhabricator

Get rid of hacky $wgPageTriageNoIndexTemplates system
Closed, ResolvedPublic0 Story Points

Description

For some reason, we're looking for a template named {{NOINDEX}} instead of looking for the presence of the magic word.

Whoever wrote the code knew this too:

		// See if article includes any templates that should trigger noindexing
		// TODO: This system is a bit hacky and unintuitive. At some point we
		// may want to switch to a system based on the __NOINDEX__ magic word.

Details

Related Gerrit Patches:
mediawiki/extensions/PageTriage : masterSimplify Hooks::shouldShowNoIndex()

Event Timeline

Legoktm created this task.Jun 20 2019, 2:42 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 20 2019, 2:42 PM
Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald Transcript

Change 518185 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/PageTriage@master] Simplify Hooks::shouldShowNoIndex()

https://gerrit.wikimedia.org/r/518185

Change 518185 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Simplify Hooks::shouldShowNoIndex()

https://gerrit.wikimedia.org/r/518185

Legoktm closed this task as Resolved.Jul 15 2019, 7:14 PM
Legoktm claimed this task.