Get rid of hacky $wgPageTriageNoIndexTemplates system
Closed, ResolvedPublic0 Estimated Story Points
Actions

Assigned To

Authored By

	Legoktm
	Jun 20 2019, 2:42 PM

Project Tags

Referenced Files

None

Subscribers

Aklapper

Legoktm

Liuxinyu970226

Description

For some reason, we're looking for a template named {{NOINDEX}} instead of looking for the presence of the magic word.

Whoever wrote the code knew this too:

		// See if article includes any templates that should trigger noindexing
		// TODO: This system is a bit hacky and unintuitive. At some point we
		// may want to switch to a system based on the __NOINDEX__ magic word.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Simplify Hooks::shouldShowNoIndex()	mediawiki/extensions/PageTriage	master	+12 -40

Customize query in gerrit

Event Timeline

Legoktm created this task.Jun 20 2019, 2:42 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 20 2019, 2:42 PM

Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald Transcript

Change 518185 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/PageTriage@master] Simplify Hooks::shouldShowNoIndex()

https://gerrit.wikimedia.org/r/518185

gerritbot added a project: Patch-For-Review.Jun 21 2019, 3:20 AM

Change 518185 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Simplify Hooks::shouldShowNoIndex()

https://gerrit.wikimedia.org/r/518185

Maintenance_bot removed a project: Patch-For-Review.Jul 15 2019, 7:10 PM

Legoktm closed this task as Resolved.Jul 15 2019, 7:14 PM

Legoktm claimed this task.

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.14; 2019-07-16).Jul 15 2019, 8:01 PM

Get rid of hacky $wgPageTriageNoIndexTemplates systemClosed, ResolvedPublic0 Estimated Story PointsActions

Description

Details

Event Timeline

Get rid of hacky $wgPageTriageNoIndexTemplates system
Closed, ResolvedPublic0 Estimated Story Points
Actions