Page MenuHomePhabricator

snak hashes should not appear in AbuseFilter text for Wikibase
Closed, ResolvedPublic

Description

This is much simpler than the matching task for statement guids described in T226216 as the "hash" key is only used for a single reason in our JSON output, for snak hashes.

Thus, removing hashes from the AF text should be as simple as adding "hash" to the arrays in the getIgnoreKeysForFilters method for items and properties in the ItemContent and PropertyContent classes.

This is technically a breaking change, so this should be announced.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 20 2019, 10:11 PM
Addshore triaged this task as Medium priority.Jun 22 2019, 10:51 PM
WMDE-leszek added subscribers: Ladsgroup, WMDE-leszek.

@Ladsgroup has done it in some different universe

@Addshore to finally verify this is done.

Restricted Application added a project: User-Addshore. · View Herald TranscriptTue, Dec 3, 1:22 PM