Maniphest T226218

snak hashes should not appear in AbuseFilter text for Wikibase
Closed, ResolvedPublic
Actions

Description

This is much simpler than the matching task for statement guids described in T226216 as the "hash" key is only used for a single reason in our JSON output, for snak hashes.

Thus, removing hashes from the AF text should be as simple as adding "hash" to the arrays in the getIgnoreKeysForFilters method for items and properties in the ItemContent and PropertyContent classes.

This is technically a breaking change, so this should be announced.

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Addshore	T204109 Investigate some Wikidata write api queries taking over 30 seconds. (In EntityContent::collectValues?)
		Resolved		Addshore	T205252 Reduce text returned by EntityContent::getTextForFilters
		Resolved		Addshore	T226218 snak hashes should not appear in AbuseFilter text for Wikibase

Event Timeline

Addshore created this task.Jun 20 2019, 10:11 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 20 2019, 10:11 PM

Addshore moved this task from Incoming to Needs Work on the Wikidata-Campsite board.Jun 20 2019, 10:11 PM

Addshore added a parent task: T205252: Reduce text returned by EntityContent::getTextForFilters.

Lydia_Pintscher added subscribers: matej_suchanek, Sjoerddebruin.Jun 21 2019, 2:29 PM

Addshore moved this task from incoming to consider for next sprint on the Wikidata board.Jun 21 2019, 10:56 PM

Addshore added a project: Performance Issue.

Addshore triaged this task as Medium priority.Jun 22 2019, 10:51 PM

Addshore moved this task from Needs Work to Ready to estimate on the Wikidata-Campsite board.Oct 28 2019, 8:22 AM

@Ladsgroup has done it in some different universe

@Addshore to finally verify this is done.

Restricted Application added a project: User-Addshore. · View Herald TranscriptDec 3 2019, 1:22 PM

WMDE-leszek moved this task from Ready to estimate to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Dec 3 2019, 1:23 PM

WMDE-leszek edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

Addshore moved this task from To Do (prioritised from top to bottom) to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 3 2019, 1:23 PM

Looks like the commits were:

https://gerrit.wikimedia.org/r/#/c/524552
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseLexeme/+/524554/

matej_suchanek removed a subscriber: matej_suchanek.Jan 10 2020, 6:57 PM