Page MenuHomePhabricator

HHVM checks only happen on submit
Open, HighPublic

Description

See https://gerrit.wikimedia.org/r/#/c/515143/. It seems not even basic linting is done in HHVM until someone attempts to merge the patch. E.g. in PS14 mediawiki-quibble-vendor-mysql-hhvm-docker failed in the gate pipeline build with Fatal error: Arrays are not allowed in class constants, but did not fail in the main test build:
https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-hhvm-docker/17565/console
https://integration.wikimedia.org/ci/job/mediawiki-quibble-vendor-mysql-hhvm-docker/16852/console

Event Timeline

Tgr created this task.Jun 22 2019, 11:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 22 2019, 11:13 PM
Tgr triaged this task as High priority.Jun 23 2019, 8:49 AM
Tgr updated the task description. (Show Details)

Also, even in the gate pipeline build, the syntax error was only caught in the unit tests, which suggests there is no HHVM linting whatsoever (presumably that would happen before phpunit) and if a class has no tests, syntax error aren't caught at all until reaching production. That seems bad.