Page MenuHomePhabricator
Create Task
Maniphest T226330

pendingElement CSS being overridden for tagMultiselectWidget
Closed, ResolvedPublic
Actions

Description

Something changed recently (in the last two months or so) and the pending-state animation has disappeared for a tagMultiselectWidget widget I've made.

I'm loading OOUI in a (non-MediaWiki) tool, and everything's working fine, but the striped scrolly thing doesn't appear while the widget's menu is loading.

It looks like there's an ordering problem in oojs-ui/dist/oojs-ui-wikimediaui.css:

  1. .oo-ui-pendingElement-pending appears on line 464, but
  2. .oo-ui-tagMultiselectWidget.oo-ui-widget-enabled .oo-ui-tagMultiselectWidget-handle on line 3081 overrides the background-color property, clobbering the pendingElement's background-image.

Details

SubjectRepoBranchLines +/-
Update OOUI to v0.35.0mediawiki/coremaster+311 -293
TagMultiselectWidget: Fix pending animation and enable it on Apexoojs/uimaster+19 -12
Customize query in gerrit

Event Timeline

Samwilson created this task.Jun 23 2019, 7:57 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 23 2019, 7:57 AM
Samwilson added a project: UploadWizard.Aug 29 2019, 12:36 AM

The pending animation is also missing for the category select widget in UploadWizard.

gerritbot added a comment.Sep 16 2019, 8:17 PM

Change 537191 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] TagMultiselectWidget: Fix pending animation and enable it on Apex

https://gerrit.wikimedia.org/r/537191

gerritbot added a project: Patch-For-Review.Sep 16 2019, 8:17 PM
Volker_E triaged this task as Medium priority.Sep 16 2019, 8:18 PM
Volker_E moved this task from Backlog to Reviewing on the OOUI board.
gerritbot added a comment.Sep 17 2019, 3:36 PM

Change 537191 merged by jenkins-bot:
[oojs/ui@master] TagMultiselectWidget: Fix pending animation and enable it on Apex

https://gerrit.wikimedia.org/r/537191

gerritbot added a comment.Oct 9 2019, 7:40 PM

Change 541905 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.35.0

https://gerrit.wikimedia.org/r/541905

gerritbot added a comment.Oct 10 2019, 11:47 PM

Change 541905 abandoned by VolkerE:
Update OOUI to v0.35.0

Reason:
for v0.35.1, which is on its way

https://gerrit.wikimedia.org/r/541905

Volker_E removed a project: Patch-For-Review.Aug 23 2021, 7:57 PM
Volker_E moved this task from Reviewing to OOUI-0.35.1 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.35.1); removed OOUI.
Volker_E closed this task as Resolved.Aug 23 2021, 8:00 PM
Volker_E assigned this task to Samwilson.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL