Page MenuHomePhabricator

Search icon on the Manage Translator Sandbox is not positioned properly on Timeless theme
Closed, ResolvedPublicBUG REPORT

Description

Steps to Reproduce:

  1. Change the Theme to Timeless
  2. Go to Manage Translator Sandbox page

Actual Results:

The search icon near the Search requests textbox is not aligned properly.

Expected Results:

The search icon should be aligned properly as per the theme guidelines. Also need to confirm in the Vector theme.

Vector:

image.png (263×1 px, 10 KB)

Timeless:

image.png (271×1 px, 13 KB)

Event Timeline

Is likely caused by timeless' form styles, especially if the icon is some sort of form element as well. But why is there a randomly floating icon in any case?

@Aklapper: I think the markup needs to be updated because it doesn't look too good in vector either. The idea is to do some research and update the tag if necessary.

Change 519248 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] Fix incorrectly aligned search icon on Timeless theme

https://gerrit.wikimedia.org/r/519248

Fixed by changing the CSS in the Translate extension,

Timeless:

image.png (428×1 px, 30 KB)

Vector:

image.png (193×1 px, 23 KB)

Change 519248 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Fix incorrectly aligned search icon on Special:ManageTranslatorSandbox

https://gerrit.wikimedia.org/r/519248

Tested with Timeless in English and Hebrew, looks good to me.

abi_ claimed this task.

Thanks @Amire80.

Resolving this task since this is now tested on Translatewiki.net.