Split from main.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Reedy | T196206 Bump symfony libraries when we no longer need hhvm support | |||
| Resolved | Reedy | T234766 Consider what PHP 7.2 point release to use | |||
| Resolved | Jdforrester-WMF | T234767 Bump PHP support version in composer.json | |||
| Resolved | Jdforrester-WMF | T216166 Drop PHP 7.1 support from MediaWiki | |||
| Resolved | Jdforrester-WMF | T216165 Drop PHP 7.0 support from MediaWiki | |||
| Resolved | Jdforrester-WMF | T225457 Move all CI generic tasks from PHP70 to PHP72 | |||
| Resolved | Jdforrester-WMF | T226420 Run phan secheck on PHP 7.2, not PHP 7.0 | |||
| Resolved | Jdforrester-WMF | T227385 Upgrade php-ast in Seccheck CI containers | |||
| Resolved | Daimona | T227172 Upgrade taint-check to 2.0.1 in all repos | |||
| Resolved | sbassett | T227171 Release taint-check 2.0.0 | |||
| Resolved | Daimona | T216974 Update phan-taint-check-plugin to a newer phan (1.3.2) | |||
| Resolved | Daimona | T218721 Have CI run seccheck tests | |||
| Resolved | Krinkle | T228342 Define criteria for setting explicit PHP support target for MediaWiki |
Event Timeline
Comment Actions
Change 517749 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] layout: Drop php70-phan-seccheck entirely
Comment Actions
Change 517750 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] jjb: Drop php70-phan-seccheck jobs, unused
Comment Actions
Copying what I said in T227172: the current version (1.5.1) requires PHP70 jobs, while the new version (2.0.0) can run on PHP70+. I believe the easier way to proceed is to first upgrade seccheck in every repo, keeping the PHP70 job alone. When all repos are upgraded (or also gradually, whatever you prefer), we'll be able to switch to PHP72 jobs and get rid of the PHP72.
Note that something that can already be done is upgrade php-ast for both seccheck jobs, in the following way:
- PHP71+ jobs: These should only have php-ast 1.0.1, and T218719 should provide anything needed for the upgrade
- PHP70 job: This one is more complicated. It should behave the same as the phan job: if there's seccheck <=1.5.1 in composer.json, it should use php-ast 0.1.2. If there's seccheck 2.0.0 it should use php-ast 1.0.0.
Given the above, and the fact that upgrading ast may be a little harder than expected (as it happened in T218719), I'm un-stalling this task in case someone is interested in giving it a try.
Comment Actions
This is directly blocked by T227172 which is itself Stalled, so surely this is also Stalled?
Comment Actions
@Jdforrester-WMF Well, T227172 is definitely a blocker and for that part yes, this one is stalled. However, as I said above, the seccheck containers have to be updated with the new php-ast, and that's something that can be done regardless of T227172. And actually, that task needs the PHP70 part described above, so they're blocking each other more or less.
Comment Actions
Yeah that makes sense :) TBH I thought that upgrading ast would have been easier, but if there's no clear solution then yes, I guess this can go back stalled.
Comment Actions
Change 521863 had a related patch set uploaded (by Jforrester; owner: Daimona Eaytoy):
[integration/config@master] dockerfiles: [mediawiki-phan-seccheck] Upgrade to PHP 7.2
Comment Actions
Change 522209 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] jjb: Point seccheck jobs at mediawiki-phan-seccheck:0.4.0
Comment Actions
Change 521863 merged by jenkins-bot:
[integration/config@master] dockerfiles: [mediawiki-phan-seccheck] Upgrade to PHP 7.2
Comment Actions
Change 522209 merged by jenkins-bot:
[integration/config@master] jjb: Point seccheck jobs at mediawiki-phan-seccheck:0.4.0
Comment Actions
Mentioned in SAL (#wikimedia-releng) [2019-07-12T00:32:50Z] <James_F> Zuul: Migrate from php70-phan-seccheck to php72-phan-seccheck T226420
Comment Actions
Change 517750 merged by jenkins-bot:
[integration/config@master] jjb: Drop php70-phan-seccheck jobs, unused