Page MenuHomePhabricator

Investigate use of vary-revision flags on group2 wikis
Closed, ResolvedPublic

Description

Now that REVISIONTIMESTAMP uses a different flag in master, the only thing left to cause vary-revision is self-transclusion (core or via Lua). Once that change goes out, any remaining use should be investigated if it is still problematic. It might be useful to add a vary-revision-hash option to handle race conditions where a page gets auto-merged and thus the self-transclusion is different than the text proposed in the save operation. Normally, I don't see why a reparse would be needed.

Details

Related Gerrit Patches:

Event Timeline

aaron created this task.Jun 24 2019, 5:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 24 2019, 5:18 PM
kchapman moved this task from Inbox to Doing on the Performance-Team board.Jun 24 2019, 7:59 PM

Change 519574 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/extensions/Scribunto@master] Add debug logging to getContentInternal() for vary-revision flag

https://gerrit.wikimedia.org/r/519574

Change 519574 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/extensions/Scribunto@master] Use "vary-revision-sha1" over "vary-revision" in getContentInternal()

https://gerrit.wikimedia.org/r/519574

Change 519574 merged by jenkins-bot:
[mediawiki/extensions/Scribunto@master] Use "vary-revision-sha1" over "vary-revision" in getContentInternal()

https://gerrit.wikimedia.org/r/519574

aaron closed this task as Resolved.Aug 8 2019, 11:02 PM

The remaining vary-revision instances are basic self-transclusions (https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/526157/ should handle those).