Page MenuHomePhabricator

FlaggedRevs form styles missing on Minerva skin
Closed, DuplicatePublic

Description

This affects all FlaggedRevs forms, including special pages for general management and the Review forms on pages themselves.

T226143: Minerva: Add support for SkinAfterContent hook provides SkinAfterContent hook support in Minerva skin. The FlaggedRevs is one of the extensions that use the SkinAfterContent hook to inject "Review this revision" form. Previously, this form wasn't visible on Minerva, so these issues were a lot less visible, but once T226143: Minerva: Add support for SkinAfterContent hook gets merged, Minerva will show the unstyled form on some of the pages themselves:

image.png (637×1 px, 36 KB)

The form looks broken

  • form elements touch each other
  • "Accept revision" button is weirdly placed
  • the Comment input is not visible - it's there, it's focusable, but it looks like there is no element there same color as footer, no borders)

Event Timeline

pmiazga renamed this task from FlaggedRevs UI broken on Mobile to FlaggedRevs "Review this revision" form styles broken on Minerva skin.Jun 25 2019, 11:35 AM

I propose we just swap it to use OOUI for the form. That should fix this, and also make people less likely to notice my, er, other change.

Isarra renamed this task from FlaggedRevs "Review this revision" form styles broken on Minerva skin to FlaggedRevs form styles missing on Minerva skin.Jun 28 2019, 2:23 PM
Isarra updated the task description. (Show Details)

Updated the task description, this actually seems to affect every FlaggedRevs form in Minerva, desktop and mobile alike, including special pages.

Also while I'm still pretty sure my above suggestion would fix them all, frankly migrating the FlaggedRevs forms to any core abstraction would probably fix this, and likely quite a few other things in other skins as well. Er.

As a workaround we could just add some really basic form styles (padding/margins, mostly) to Minerva to covet this sort of thing in general, like I did in Timeless (https://gerrit.wikimedia.org/r/c/mediawiki/skins/Timeless/+/504963/6/resources/forms.less). I think it mostly turned out to be fine even with all the other weird assumptions in mw, but definitely don't do the 'wat' thing, that was indeed an awful idea.

Change 519694 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/extensions/FlaggedRevs@master] Attempt to convert Special:Stabilization to OOUI

https://gerrit.wikimedia.org/r/519694

Change 520116 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/extensions/FlaggedRevs@master] Convert RevisionReviewForm to OOUI

https://gerrit.wikimedia.org/r/520116

T191156: Convert FlaggedRevisions to OOUI would fix it. The extension is really hard to work with though.