Page MenuHomePhabricator

API req from Special:UrlShortener emits PHP error "Undefined index: query"
Closed, ResolvedPublic

Description

Error

Request URL: POST metawiki /w/api.php, referer https://meta.wikimedia.org/wiki/Special:UrlShortener
Request ID: XRHDJQpAEDUAAIIOLckAAACD

message
PHP Notice: Undefined index: query
trace
#0 /srv/mediawiki/php-1.34.0-wmf.10/extensions/UrlShortener/includes/UrlShortenerUtils.php(136): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.34.0-wmf.10/extensions/UrlShortener/includes/UrlShortenerUtils.php(46): UrlShortenerUtils::normalizeUrl(string)
#2 /srv/mediawiki/php-1.34.0-wmf.10/extensions/UrlShortener/includes/ApiShortenUrl.php(28): UrlShortenerUtils::maybeCreateShortCode(string, User)
#3 /srv/mediawiki/php-1.34.0-wmf.10/includes/api/ApiMain.php(1595): ApiShortenUrl->execute()
#4 /srv/mediawiki/php-1.34.0-wmf.10/includes/api/ApiMain.php(531): ApiMain->executeAction()
#5 /srv/mediawiki/php-1.34.0-wmf.10/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#6 /srv/mediawiki/php-1.34.0-wmf.10/api.php(87): ApiMain->execute()
#7 /srv/mediawiki/w/api.php(3): include(string)

Impact

Unknown.

Notes

Seen in Logstash since at least php-1.34.0-wmf.6, affects both PHP 7.2 and HHVM backends.

Details

Related Gerrit Patches:
mediawiki/extensions/UrlShortener : masterNormalize plain domains to have a trailing slash after them

Event Timeline

Krinkle created this task.Jun 25 2019, 1:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 25 2019, 1:40 PM

Change 512615 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/UrlShortener@master] Normalize plain domains to have a trailing slash after them

https://gerrit.wikimedia.org/r/512615

Legoktm claimed this task.Jun 25 2019, 4:13 PM

Change 512615 merged by jenkins-bot:
[mediawiki/extensions/UrlShortener@master] Normalize plain domains to have a trailing slash after them

https://gerrit.wikimedia.org/r/512615

Jdforrester-WMF closed this task as Resolved.Jun 25 2019, 11:00 PM
mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:06 PM