Track how often the automated edits on the source wiki failed
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Acceptance Criteria

On the FileImporter grafana board track how often the attempt to edit the source wiki failed, and how often it was successful
This should happen in a seperate panel, so that the move failure panel metrics are not influenced.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/FileImporter	master	+38 -8	Track remote edit success and failure stats

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Andrew-WMDE	T226513 Track how often the automated edits on the source wiki failed
		Resolved		awight	T228851 Source wiki editing and deletion always fails

Event Timeline

Lea_WMDE created this task.Jun 25 2019, 2:31 PM

Restricted Application added a project: archived--TCB-Team. · View Herald TranscriptJun 25 2019, 2:31 PM

Lea_WMDE set the point value for this task to 3.Jun 25 2019, 2:31 PM

WMDE-Fisch added a project: WMDE-QWERTY-Sprint-2019-06-26.Jun 26 2019, 12:41 PM

WMDE-Fisch moved this task from Tickets ready for pickup to Tickets in sprint on the Move-Files-To-Commons board.

Assuming we should also track how often deletions fail, maybe in a separate graph.

awight claimed this task.Jul 2 2019, 2:11 PM

awight moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2019-06-26 board.

Change 520246 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/FileImporter@master] Track remote edit success and failure stats

https://gerrit.wikimedia.org/r/520246

gerritbot added a project: Patch-For-Review.Jul 2 2019, 2:22 PM

awight moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2019-06-26 board.Jul 2 2019, 2:23 PM

awight mentioned this in rEFLI5edb42425247: Track remote edit success and failure stats.Jul 2 2019, 2:25 PM

awight mentioned this in rEFLI4694e04d9d5d: Track remote edit success and failure stats.Jul 2 2019, 2:41 PM

Change 520246 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Track remote edit success and failure stats

https://gerrit.wikimedia.org/r/520246

Maintenance_bot removed a project: Patch-For-Review.Jul 4 2019, 11:10 AM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.13; 2019-07-09).Jul 4 2019, 12:00 PM

WMDE-Fisch mentioned this in rEFLI5644e701fc4a: Track remote edit success and failure stats.Jul 4 2019, 12:14 PM

Needs the grafana panel.

WMDE-Fisch added a project: WMDE-QWERTY-Spike-2019-07-09.Jul 9 2019, 11:36 AM

WMDE-Fisch changed the point value for this task from 3 to 1.

Tobi_WMDE_SW moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Spike-2019-07-09 board.Jul 9 2019, 11:38 AM

awight moved this task from Doing to Watching on the WMDE-QWERTY-Spike-2019-07-09 board.Jul 11 2019, 9:10 AM

I'm concerned that we might not be recording failures, instead the control flow hits the outer exception handling block.

awight moved this task from Watching to Doing on the WMDE-QWERTY-Spike-2019-07-09 board.Jul 22 2019, 11:34 AM

The rough graphs are up, and they show that we have a big problem. Source wiki edits and deletes always fail, we haven't recorded a single success.

awight mentioned this in T228851: Source wiki editing and deletion always fails.Jul 24 2019, 11:35 AM

awight moved this task from Doing to Sprint Backlog on the WMDE-QWERTY-Spike-2019-07-09 board.

What is there left to do for the completion of this ticket?

Lea_WMDE moved this task from Tickets in sprint to Tickets ready for pickup on the Move-Files-To-Commons board.Jul 25 2019, 9:56 AM

In T226513#5364445, @Lea_WMDE wrote:

What is there left to do for the completion of this ticket?

We should probably try to get more specific information on whey the source edit/deletion fails. - Also, when looking at the numbers, I'm not sure how big the issue really is, since we do not exactly know how the tried/failed ratio is.

tl;dr: