ApiQueryReadingListsTest and ApiQueryReadingListEntriesTest have two failures each where the API response is unexpected: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ReadingLists/+/519222
Description
Description
Details
Details
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| mediawiki/extensions/ReadingLists | wmf/1.34.0-wmf.11 | +4 -4 | Fix API continuation | |
| mediawiki/extensions/ReadingLists | master | +4 -4 | Fix API continuation |
Related Objects
Related Objects
- Mentioned In
- T227665: Announce or revert ResultWrapper iteration change
rERLS84ff5f475968: Fix API continuation
T93414: Regularly run mwext-{name}-testextension-* jobs to make sure they are still passing after core or dependency changes
T226762: [Bug] GET /data/lists doesn't include "next" in an incomplete response
rERLS151625b93bc9: Fix API continuation - Mentioned Here
- rMWd9f688698ce0: rdbms: clean up and refactor ResultWrapper classes
Event Timeline
Comment Actions
Apparently rMWd9f688698ce0: rdbms: clean up and refactor ResultWrapper classes has changed the indexing of ResultWrapper from 1-based to 0-based, so query continuation in Reading Lists was broken for almost a month :(
Comment Actions
Change 519270 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/ReadingLists@master] Fix API continuation
Comment Actions
Change 519270 merged by jenkins-bot:
[mediawiki/extensions/ReadingLists@master] Fix API continuation
Comment Actions
Change 520480 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/ReadingLists@wmf/1.34.0-wmf.11] Fix API continuation
Comment Actions
Change 520480 merged by jenkins-bot:
[mediawiki/extensions/ReadingLists@wmf/1.34.0-wmf.11] Fix API continuation
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2019-07-03T16:23:36Z] <urbanecm@deploy1001> Synchronized php-1.34.0-wmf.11/extensions/ReadingLists/: SWAT: [[:gerrit:520480|Fix API continuation]] (T226640) (duration: 00m 49s)