Page MenuHomePhabricator

Review Edit Cards v2.0 implementation for remaining context items
Closed, ResolvedPublic

Description

Task overview

This tasks involves the work with deciding how the Edit Cards v2.0 designs – T225725 – should be applied/translated to other VE context items on mobile and desktop.

Open questions

  • 1. Create an exhaustive list of context items that needs to be considered
    • I, Peter, ask "1." as someone who has not been involved with these conversations. If y'all (Ed and Jess) have figured this out, please tell me and I'll strike this out.

"Done"

  • Engineering knows how the Edit Cards v2.0 designs should be applied to all remaining context items in VE, on mobile and desktop.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 26 2019, 10:26 PM
ppelberg updated the task description. (Show Details)EditedJun 26 2019, 10:27 PM

Re: the application of the design.
I see this design being easily translatable to other contexts. Here is what it will look like for a citation (also added to freehand). @Esanders has pointed out that this wouldn't be a perfect 1:1 fit for some contexts which don't have a description such as gallery and math. I will work on thinking those through next.

I mocked up a version of several applications of the design.
Please drop feedback into the Invision doc.

These designs include:

  • maps
  • gallery
  • math
  • citation
  • unknown with no content specified

We went with a minimal version of the implementation for V2.
We should tackle each individual context treatment separately and break them out into individual separate tickets.

iamjessklein updated the task description. (Show Details)
iamjessklein closed this task as Resolved.Jul 24 2019, 5:07 PM

We should tackle each individual context treatment separately and break them out into individual separate tickets.

@iamjessklein, where – if at all – do the tickets for this follow up work live? Have they been created yet?

...my instinct was to search Phab for open tickets authored by you, but I didn't immediately see any tickets that looked like they referred to this work. See Phab search: https://phabricator.wikimedia.org/search/query/38TVc.x5hQjg/#R