Ensure that JS & PHP imageinfo requests return responsive urls in the same order
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ssastry
	Jun 27 2019, 4:15 AM

Description

This is output after adding logging to AddMediaInfo pass just before these urls are added to the srcset attribute.

[subbu@earth:~/work/wmf/parsoid] echo "[[File:Foo.jpg|thumb]]" | php bin/parse.php --wt2html > /dev/null
RESPONSIVE URLS: {"1.5":"https:\/\/upload.wikimedia.org\/wikipedia\/commons\/0\/06\/Foo.jpg","2":"https:\/\/upload.wikimedia.org\/wikipedia\/commons\/0\/06\/Foo.jpg"}
[subbu@earth:~/work/wmf/parsoid] echo "[[File:Foo.jpg|thumb]]" | parse.js --useBatchAPI > /dev/null
RESPONSIVE URLS: {"2":"https://upload.wikimedia.org/wikipedia/commons/0/06/Foo.jpg","1.5":"https://upload.wikimedia.org/wikipedia/commons/0/06/Foo.jpg"}

This causes spurious diffs when comparing output of PHP and JS runs.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+8 -0	Return responsiveUrls (srcset info) in ApiQueryImageInfo response
	mediawiki/services/parsoid	master	+3 -0	Sort responsive url list just like Parsoid/JS would (reverse density)

Customize query in gerrit

Related Objects

Mentioned In: T234932: Parsoid srcset is inconsistent with core
T234697: Script to compare Parsoid/PHP and Parsoid/JS HTML

Event Timeline

ssastry created this task.Jun 27 2019, 4:15 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 27 2019, 4:15 AM

ssastry triaged this task as Medium priority.Jun 27 2019, 4:15 AM

ssastry updated the task description. (Show Details)

ssastry moved this task from Backlog to Testing / QA on the Parsoid-PHP board.Aug 29 2019, 3:29 PM

Change 540973 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Sort responsive url list just like Parsoid/JS would (reverse density)

https://gerrit.wikimedia.org/r/540973

gerritbot added a project: Patch-For-Review.Oct 4 2019, 9:41 PM

ssastry claimed this task.Oct 4 2019, 9:41 PM

ssastry mentioned this in T234697: Script to compare Parsoid/PHP and Parsoid/JS HTML.Oct 4 2019, 9:49 PM

cscott mentioned this in T234932: Parsoid srcset is inconsistent with core.Oct 8 2019, 2:59 PM

Change 540973 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Sort responsive url list just like Parsoid/JS would (reverse density)

https://gerrit.wikimedia.org/r/540973

Maintenance_bot removed a project: Patch-For-Review.Oct 8 2019, 3:10 PM

ssastry closed this task as Resolved.Oct 12 2019, 4:21 AM

Change 618169 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Return responsiveUrls (srcset info) in ApiQueryImageInfo response

https://gerrit.wikimedia.org/r/618169

gerritbot added a project: Patch-For-Review.Aug 4 2020, 5:03 AM

Change 618169 merged by jenkins-bot:
[mediawiki/core@master] Return responsiveUrls (srcset info) in ApiQueryImageInfo response

https://gerrit.wikimedia.org/r/618169

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.4; 2020-08-11).Aug 4 2020, 11:00 AM

Maintenance_bot removed a project: Patch-For-Review.Aug 4 2020, 11:10 AM

Ensure that JS & PHP imageinfo requests return responsive urls in the same orderClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Ensure that JS & PHP imageinfo requests return responsive urls in the same order
Closed, ResolvedPublic
Actions