Page MenuHomePhabricator

Update Echo compatibility styles for Wikimedia-deployed skins
Closed, ResolvedPublic

Description

Recent thing changed how badges display (T139779). No particular issues with this in most skins, but probably should still make sure the other skins in gerrit don't have any weird artefacts from this either, based on the following. Ones with support usually do so with a +ext.echo.styles.badge set of styles in the skin itself, typically a line to make the badges display inline or whatever.

Wikimedia-deployed skins tend to have more special styles for compatibility in Echo itself - sometimes a lot more than just formatting the badges. Most of these are probably redundant at this point or could be moved into the skins themselves, and some of them appear to be causing issues with the new badge implementation. Thus what needs updating is two-fold:

  1. Support for the new badge display implementation: MonoBook and Modern in particular have been reported as having issues with repeating badge backgrounds, missing badges, whatever.
  2. Whether or not the other special styles still make sense either, and removal if not in order to ensure similar to the above doesn't occur in with any relevant future changes with what these change.

Wikimedia-deployed skins that need this are:

  • Vector (no issues in terms of #1, but should still be worth looking into for #2)
  • Modern (confirmed issues with #1)
  • CologneBlue (no apparent new issues with #1, but might be worth adding some better compat, etc)
  • MonoBook (confirmed issues with #1, some of this might just be the mobile nonsense, but whatever here: T226594 etc etc)

Minerva is a bit of a special case in terms of where its styles reside and how it interacts with Echo to begin with so we can likely safely ignore it here. Timeless likewise just has its own handling as it's a bit newer than the others, and likewise appears unaffected.

Event Timeline

Isarra created this task.Jun 27 2019, 4:41 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 27 2019, 4:41 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 27 2019, 4:42 AM

For cologneblue I mean we should probably just do this and maybe add some extra vertical padding if need be: https://gerrit.wikimedia.org/r/c/mediawiki/skins/Mask/+/519058

Change 519571 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/CologneBlue@master] Put echo badges on a single line

https://gerrit.wikimedia.org/r/519571

CologneBlue confirmed not to have any special styles to begin with. Also has issues with alignment of the flyouts, as echo apparently really doesn't like being in the left sidebar. T226786

Regardless, calling that one done here.

Change 519571 merged by jenkins-bot:
[mediawiki/skins/CologneBlue@master] Put echo badges on a single line

https://gerrit.wikimedia.org/r/519571

Change 519579 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/extensions/Echo@master] Remove outdated skin styles

https://gerrit.wikimedia.org/r/519579

Change 519580 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Modern@master] Fix handling for echo badges (ooui)

https://gerrit.wikimedia.org/r/519580

Echo + Modern needs more fixes in general (such as the ludicrously tiny text - T184295), but should now have parity with how it was before the badge change, so eeeeh good enough?

Change 519587 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/MonoBook@master] Echo compatibility: use float: right instead of text-align: right on personal tools

https://gerrit.wikimedia.org/r/519587

Change 519591 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/extensions/Echo@master] MonoBook: Remove outdated skin styles and clean up some

https://gerrit.wikimedia.org/r/519591

Okay, MonoBook done, I guess.

And Vector is fine, nothing to do there.

Change 519587 merged by jenkins-bot:
[mediawiki/skins/MonoBook@master] Echo compatibility: use float: right instead of text-align: right on personal tools

https://gerrit.wikimedia.org/r/519587

Change 519579 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Modern: Remove outdated skin styles

https://gerrit.wikimedia.org/r/519579

Change 519580 merged by jenkins-bot:
[mediawiki/skins/Modern@master] Fix handling for echo badges (ooui)

https://gerrit.wikimedia.org/r/519580

Change 519591 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] MonoBook: Remove outdated skin styles and clean up some

https://gerrit.wikimedia.org/r/519591

Isarra closed this task as Resolved.Jun 29 2019, 3:23 AM
Isarra claimed this task.

I participated!

Change 520325 had a related patch set uploaded (by Catrope; owner: Isarra):
[mediawiki/skins/MonoBook@wmf/1.34.0-wmf.11] Echo compatibility: use float: right instead of text-align: right on personal tools

https://gerrit.wikimedia.org/r/520325

Change 520326 had a related patch set uploaded (by Catrope; owner: Isarra):
[mediawiki/extensions/Echo@wmf/1.34.0-wmf.11] MonoBook: Remove outdated skin styles and clean up some

https://gerrit.wikimedia.org/r/520326

Change 520326 merged by jenkins-bot:
[mediawiki/extensions/Echo@wmf/1.34.0-wmf.11] MonoBook: Remove outdated skin styles and clean up some

https://gerrit.wikimedia.org/r/520326

Change 520325 merged by jenkins-bot:
[mediawiki/skins/MonoBook@wmf/1.34.0-wmf.11] Echo compatibility: use float: right instead of text-align: right on personal tools

https://gerrit.wikimedia.org/r/520325

@Isarra Thank you for working on this!