Page MenuHomePhabricator

Add mw-disambig class to original content in VE
Closed, ResolvedPublic

Description

When you add a link to a disambiguation page in VE, the class mw-disambig is set on the link, like in read view.
But this only works for newly added links, the class is missing for links already present when you start editing. (And it also isn't added when you add a new link to a disambiguation page that already was present before.)

To test: https://de.wikipedia.org/wiki/0 has the link 00, which has the mw-disambig class in read view, and thus should still have this class when you start editing in VE. According to T149794, Parsoid should actually be able to add that class, but apparently it is missing still.

Event Timeline

Schnark created this task.Jun 27 2019, 7:48 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptJun 27 2019, 7:48 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
JTannerWMF moved this task from To Triage to Freezer on the VisualEditor board.Jul 2 2019, 4:48 PM
JTannerWMF added a subscriber: JTannerWMF.

We are not prioritizing this work at the moment

I'm not actually seeing the disambig class in the Parsoid output: https://de.wikipedia.org/api/rest_v1/page/html/0/187176557

ssastry added a subscriber: ssastry.Jul 2 2019, 4:58 PM

This bug should have been fixed with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ParsoidBatchAPI/+/517479 ... but, maybe that hasn't been deployed to production yet? Or, maybe refresh that page to check?

This bug should have been fixed with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ParsoidBatchAPI/+/517479 ... but, maybe that hasn't been deployed to production yet? Or, maybe refresh that page to check?

https://www.mediawiki.org/wiki/MediaWiki_1.34/wmf.10/Changelog#ParsoidBatchAPI says this went out in wmf-10 .. so, let me refresh that page.

This bug should have been fixed with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ParsoidBatchAPI/+/517479 ... but, maybe that hasn't been deployed to production yet? Or, maybe refresh that page to check?

https://www.mediawiki.org/wiki/MediaWiki_1.34/wmf.10/Changelog#ParsoidBatchAPI says this went out in wmf-10 .. so, let me refresh that page.

Yes, Fixed. ?action=purge fixed it. So, as pages refresh over time, these classes will show up.

matmarex closed this task as Resolved.Jul 2 2019, 5:32 PM

Huh, thanks!

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJul 2 2019, 5:32 PM