Page MenuHomePhabricator
Create Task
Maniphest T226708

New mobile link context doesn't work on single character links
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (75510a515)mediawiki/extensions/VisualEditormaster+4 -1
Gather annotations from clicked node where possibleVisualEditor/VisualEditormaster+21 -10
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Jun 27 2019, 11:47 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptJun 27 2019, 11:47 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Jun 27 2019, 11:48 AM

Change 519377 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Gather annotations from clicked node where possible

https://gerrit.wikimedia.org/r/519377

gerritbot added a project: Patch-For-Review.Jun 27 2019, 11:48 AM
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.Jun 27 2019, 11:48 AM
Esanders added a comment.Jun 27 2019, 11:52 AM

The root cause is T221967.

matmarex moved this task from Incoming to Code review on the VisualEditor (Current work) board.Jul 1 2019, 4:01 PM
gerritbot added a comment.Jul 1 2019, 9:42 PM

Change 520127 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] ve.ui.AnnotationContextItem: Use ve.ce.Surface's logic for detecting annotations

https://gerrit.wikimedia.org/r/520127

gerritbot added a comment.Jul 1 2019, 9:44 PM

Change 519377 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Gather annotations from clicked node where possible

https://gerrit.wikimedia.org/r/519377

matmarex mentioned this in T221967: Can't reliably gather list of annotation views from a DM offset.Jul 1 2019, 9:46 PM
matmarex subscribed.
gerritbot added a comment.Jul 3 2019, 5:12 PM

Change 520500 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (dc0e4650e)

https://gerrit.wikimedia.org/r/520500

gerritbot added a comment.Jul 4 2019, 12:43 AM

Change 520500 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (75510a515)

https://gerrit.wikimedia.org/r/520500

matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Jul 4 2019, 12:45 AM

The workaround fixes this, but there are problems within the context when the link consists of just one character. I filed a separate task about this: T227241 and moved the patch https://gerrit.wikimedia.org/r/520127 there. Please ignore that problem in QA, we'll get back to it :)

matmarex removed a project: Patch-For-Review.Jul 4 2019, 12:45 AM
matmarex added a project: Editing QA.
matmarex moved this task from Inbox to High Priority on the Editing QA board.
matmarex added a project: VisualEditor-DataModel.Jul 4 2019, 12:48 AM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.13; 2019-07-09).Jul 4 2019, 1:00 AM
Ryasmeen edited projects, added Verified; removed Editing QA.Aug 22 2019, 9:02 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
• ppelberg closed this task as Resolved.Sep 3 2019, 1:52 AM
• ppelberg claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL