wgRestrictionsEdit changed from array to object in JS variables served on each page: breaks a great many Javascripts
Closed, ResolvedPublic

Description

r56032 breaks a great many Javascripts checking wgRestrictionEdit.

The following change

http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/Xml.php?r1=55842&r2=56032&pathrev=56032

makes that variable become an object (wgRestrictionEdit = {}) if the array is empty,
whereas previously it was an array (wgRestrictionEdit = []). Please revert ASAP (and push the revert to live wikis).

See also

http://commons.wikimedia.org/w/index.php?title=Commons:Village_pump#Problem_with_javascript_gadgets


Version: unspecified
Severity: major

bzimport added a project: MediaWiki-Interface.Via ConduitNov 21 2014, 10:52 PM
bzimport set Reference to bz20671.
Lupo created this task.Via LegacySep 17 2009, 8:25 AM
bzimport added a comment.Via ConduitSep 17 2009, 9:31 AM

eusebius wrote:

I concur, we (Commons users, probably users on other projects as well) are much handicapped by this change in our everyday activities (which, for some, have become impossible).

werdna added a comment.Via ConduitSep 17 2009, 9:58 AM

Backwards-compatibility fix committed in r56497, deployed.

Add Comment