Page MenuHomePhabricator
Create Task
Maniphest T226737

Enable Phan and seccheck on WebAuthn extension
Closed, ResolvedPublic
Actions

Description

When we have some code merged, we should ideally get extension-phan and extension-seccheck running on the WebAuthn repo (like we do elsewhere and also on OATHAuth)

But extension-seccheck does have tests running on php70 built in... So we might want to use extension-seccheck-non-voting instead and just take note of php72 fails... Or rather than adding more skip-if for it...

Details

SubjectRepoBranchLines +/-
Make seccheck voting on WebAuthnintegration/configmaster+1 -1
Enable extension-seccheck-non-voting on WebAuthnintegration/configmaster+1 -0
Enable phan on WebAuthnintegration/configmaster+1 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Reedy created this task.Jun 27 2019, 4:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 27 2019, 4:55 PM
gerritbot added a comment.Jun 27 2019, 4:59 PM

Change 519454 had a related patch set uploaded (by Reedy; owner: Reedy):
[integration/config@master] Enable phan on WebAuthn

https://gerrit.wikimedia.org/r/519454

gerritbot added a project: Patch-For-Review.Jun 27 2019, 4:59 PM

Change 519455 had a related patch set uploaded (by Reedy; owner: Reedy):
[integration/config@master] Enable extension-seccheck-non-voting on WebAuthn

https://gerrit.wikimedia.org/r/519455

gerritbot added a comment.Jun 27 2019, 4:59 PM

Change 519456 had a related patch set uploaded (by Reedy; owner: Reedy):
[integration/config@master] Make seccheck voting on WebAuthn

https://gerrit.wikimedia.org/r/519456

gerritbot added a comment.Jun 27 2019, 5:03 PM

Change 519454 merged by jenkins-bot:
[integration/config@master] Enable phan on WebAuthn

https://gerrit.wikimedia.org/r/519454

gerritbot added a comment.Jun 27 2019, 5:38 PM

Change 519455 merged by jenkins-bot:
[integration/config@master] Enable extension-seccheck-non-voting on WebAuthn

https://gerrit.wikimedia.org/r/519455

Jdforrester-WMF closed subtask T226752: mwext-php72-phan-docker running composer under PHP 7.0 as Resolved.Jul 1 2019, 6:51 PM
hashar reopened subtask T226752: mwext-php72-phan-docker running composer under PHP 7.0 as Open.Jul 2 2019, 8:57 AM
Reedy added a subtask: T227043: ext-gmp/ext-bcmath missing for Phan jobs based on php 7.2.Jul 4 2019, 6:49 PM
WDoranWMF moved this task from Contractor - Doing to S&F Workboard on the Platform Team Workboards board.Jul 5 2019, 4:53 PM
WDoranWMF edited projects, added Platform Team Workboards (S&F Workboard); removed Platform Team Workboards (Contractor - Doing).
WDoranWMF moved this task from Backlog to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.
Jdforrester-WMF closed subtask T227043: ext-gmp/ext-bcmath missing for Phan jobs based on php 7.2 as Resolved.Jul 12 2019, 12:53 AM
Jdforrester-WMF closed subtask T226752: mwext-php72-phan-docker running composer under PHP 7.0 as Resolved.
gerritbot added a comment.Jul 12 2019, 10:09 PM

Change 519456 merged by jenkins-bot:
[integration/config@master] Make seccheck voting on WebAuthn

https://gerrit.wikimedia.org/r/519456

Maintenance_bot removed a project: Patch-For-Review.Jul 12 2019, 10:10 PM
Stashbot added a comment.Jul 12 2019, 10:10 PM

Mentioned in SAL (#wikimedia-releng) [2019-07-12T22:10:27Z] <James_F> Zuul: Make seccheck voting on WebAuthn T226737

Jdforrester-WMF closed this task as Resolved.Jul 12 2019, 10:10 PM
Jdforrester-WMF claimed this task.
CCicalese_WMF edited projects, added Platform Team Initiatives (Two-Factor Authentication (TEC1)); removed Platform Engineering (Needs Cleaning - Security, stability, performance, and scalability (TEC1)).Jul 27 2019, 4:14 PM
CCicalese_WMF moved this task from In Progress/Doing to Done on the Platform Team Workboards (S&F Workboard) board.Aug 30 2019, 8:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL