Page MenuHomePhabricator

WebVideoTranscodeJob fatal: Call to getStdout() on a non-object
Closed, ResolvedPublic

Description

Error

Request URL: (jobrunners: videoscaler)
Request ID: eb4456d8425cf8b81799c7f5

message
BadMethodCallException: Call to a member function getStdout() on a non-object (null)
trace
#0 /srv/mediawiki/php-1.34.0-wmf.11/extensions/TimedMediaHandler/includes/WebVideoTranscode/WebVideoTranscodeJob.php(202): WebVideoTranscodeJob->midiToAudioEncode(array)
#1 /srv/mediawiki/php-1.34.0-wmf.11/extensions/EventBus/includes/JobExecutor.php(64): WebVideoTranscodeJob->run()
#2 /srv/mediawiki/rpc/RunSingleJob.php(76): JobExecutor->execute(array)
#3 {main}

Impact

The transcode job is not able to complete. Given the error appears deterministic, it might mean that some media files are unavailable to some groups of users.

Notes

Seen for the first time on 1.34.0-wmf.11. Not seen in the 30 days prior.

code (WebVideoTranscode.php)
	$shellOutput = $this->runShellExec( $cmdString, $retval );

	// Fluidsynth doesn't give error codes - $retval always stays 0
	if ( strpos( $shellOutput, "fluidsynth: error:" ) !== false ) {
		return $cmdString .
			"\n\nExitcode: $retval\nMemory: $wgTranscodeBackgroundMemoryLimit\n\n" .
			$cmd->getStdout();

Added in 19aabab261960d5a2 / https://gerrit.wikimedia.org/r/511015 (T20852, T135597).

Event Timeline

Krinkle created this task.Jun 27 2019, 5:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 27 2019, 5:38 PM
brion claimed this task.Jun 27 2019, 9:08 PM

Change 519525 had a related patch set uploaded (by Brion VIBBER; owner: Brion VIBBER):
[mediawiki/extensions/TimedMediaHandler@master] Fix a broken error case handler in midi transcoding

https://gerrit.wikimedia.org/r/519525

Krinkle triaged this task as High priority.Jun 27 2019, 9:19 PM

Change 519528 had a related patch set uploaded (by Krinkle; owner: Brion VIBBER):
[mediawiki/extensions/TimedMediaHandler@wmf/1.34.0-wmf.11] Fix a broken error case handler in midi transcoding

https://gerrit.wikimedia.org/r/519528

Change 519525 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Fix a broken error case handler in midi transcoding

https://gerrit.wikimedia.org/r/519525

Mentioned in SAL (#wikimedia-operations) [2019-06-27T21:44:08Z] <brion> deploying fix for TMH jobqueue bug T226748

Change 519528 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@wmf/1.34.0-wmf.11] Fix a broken error case handler in midi transcoding

https://gerrit.wikimedia.org/r/519528

brion closed this task as Resolved.Jun 27 2019, 9:53 PM

Fix deployed. Should no longer cause fatal errors, but should log the transcoder output into the transcode table so we can review it later for suspicious commonalities.

Note a deployment typo caused this fix to not get deployed in fact. Whoops! Roan's fixing it now.

Mentioned in SAL (#wikimedia-operations) [2019-06-27T23:25:48Z] <brion> roan is fixing deploy of T226748 which failed to include the patch (whoops)

Mentioned in SAL (#wikimedia-operations) [2019-06-27T23:28:56Z] <catrope@deploy1001> Synchronized php-1.34.0-wmf.11/extensions/TimedMediaHandler/: T226748 (duration: 00m 50s)