Page MenuHomePhabricator

Implement Information Bar for Who Wrote That
Closed, ResolvedPublic5 Estimated Story Points

Assigned To
Authored By
ifried
Jun 27 2019, 9:02 PM
Referenced Files
F29931311: wwtinfobararticle.png
Aug 1 2019, 3:57 PM
F29931313: wwtinfobarthreestates.png
Aug 1 2019, 3:57 PM
F29851666: wwtbarmessages.png
Jul 23 2019, 7:16 PM
F29851661: wwtbarplacement.png
Jul 23 2019, 7:16 PM

Description

As a user, I want to view the information bar when I toggle on WhoWroteThat, so that I can view WWT instructions and data in a visually-appealing manner.

  • Note #1: This work is dependent on T226761 for the final product, but it can be developed independently.
  • Note #2: The data displayed in the blue bar will be presented in different tickets (T226746 and T226760). This ticket only focuses on the basic implementation of the blue bar.

Requirements:

  • When WWT is activated, a blue information bar should appear at the top of the article.
  • The information bar should be displayed below the links ("Read," "Edit," "View History," "Article," or "Talk") and above the article title.
  • The information bar should not block any links on the page.
  • The whitespace dimensions at the top of the article should remain the same.
  • The information bar should be sticky.
  • The information bar should be implemented in such a way that it can adapt to different states. For example, if there is an API error, the bar may change (e.g. a different color). However, the actual handling of error behavior will be covered in a separate ticket.
    • Technical implementation: Create three states for the bar "widget": 'ready', 'pending', and 'error'; each state's display is available in the image below. The actual calling of those states will be implemented in another ticket, but the original 'bar widget' should be ready to display the three states.

Visual Examples:

Note: For the visual specifications, you may refer to the CSS provided in the Zeplin project link. You can click on a particular element to see detailed CSS info.

wwtinfobararticle.png (927×530 px, 303 KB)

wwtinfobarthreestates.png (923×372 px, 43 KB)

Event Timeline

ifried updated the task description. (Show Details)
ifried updated the task description. (Show Details)
Mooeypoo updated the task description. (Show Details)
MBinder_WMF renamed this task from Implement Information Bar to Implement Information Bar for Who Wrote That.Aug 1 2019, 5:10 PM
ifried set the point value for this task to 5.Aug 1 2019, 5:14 PM
  • When WWT is activated, a blue information bar should appear at the top of the article.
  • The information bar should be displayed below the links ("Read," "Edit," "View History," "Article," or "Talk") and above the article title.
  • I've checked on this for Vector, Monobook and Timeless. There are minor annoyances with the icons in Monobook and Timeless, but it is working.
  • The information bar should not block any links on the page.
  • The whitespace dimensions at the top of the article should remain the same.
  • The information bar should be sticky.
  • The information bar should be implemented in such a way that it can adapt to different states. For example, if there is an API error, the bar may change (e.g. a different color). However, the actual handling of error behavior will be covered in a separate ticket.
  • The widget changes state with widget.setState( state ) where state can be pending, ready, and err.
dom_walden subscribed.

Requirements:

  • When WWT is activated, a blue information bar should appear at the top of the article.
  • The information bar should be displayed below the links ("Read," "Edit," "View History," "Article," or "Talk") and above the article title.

Yep.

Appears only for articles in the Main namespace.

I have tested tested it on Chromium 73 and Firefox 60.

I experimented briefly with different common screen sizes (1024 x 786, 1280 x 1024, 1920 x 1080).

  • The information bar should not block any links on the page.

I also checked that it does not interfere with the "More" dropdown or the search suggestions. They appear "above" the information bar.

  • The whitespace dimensions at the top of the article should remain the same.

Not sure exactly what this means. Obviously the information bar takes up some space. Things below it are moved down. Otherwise, everything appears to stay the same.

  • The information bar should be sticky.

Yep.

  • The information bar should be implemented in such a way that it can adapt to different states. For example, if there is an API error, the bar may change (e.g. a different color). However, the actual handling of error behavior will be covered in a separate ticket.
    • Technical implementation: Create three states for the bar "widget": 'ready', 'pending', and 'error'; each state's display is available in the image below. The actual calling of those states will be implemented in another ticket, but the original 'bar widget' should be ready to display the three states.

So far, only the 'pending' state is implemented.

Thanks, @dom_walden. The "whitespace" related requirement simply meant that, with these changes, there should still be whitespace between the article title and the top of the article (which is now where the information bar ends).

Since WWT won't follow a traditional release cycle, I'll mark such work as 'Done' when it has been demoed or tested. In this case, the information bar was recently demoed to the team, so it can be marked as 'Done.'