Page MenuHomePhabricator
Create Task
Maniphest T226785

Phase out use of vary-revision with more specific flags and improve related logging
Closed, ResolvedPublic
Actions

Description

This is important for getting the edit stash hit rate up and improving save timing in general (regardless of stashing).

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
parser: use 'vary-revision-sha1' in Parser::statelessFetchTemplateAaron Schulzmediawiki/coremaster+17 -11
Add missing title info in RenderedRevision::outputVariesOnRevisionMetaData()Aaron Schulzmediawiki/coremaster+1 -1
parser: add speculative page IDs to use with {{PAGEID}}Aaron Schulzmediawiki/coremaster+169 -69
parser: inject a Logger into Parser instead of using wfDebug()Aaron Schulzmediawiki/coremaster+98 -63
Customize query in gerrit

Related Objects

Event Timeline

aaron created this task.Jun 27 2019, 11:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 27 2019, 11:09 PM
gerritbot added a comment.Jun 27 2019, 11:13 PM

Change 519352 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] parser: add speculative page IDs to use with {{PAGEID}}

https://gerrit.wikimedia.org/r/519352

gerritbot added a project: Patch-For-Review.Jun 27 2019, 11:13 PM
gerritbot added a comment.Jun 27 2019, 11:17 PM

Change 519351 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] parser: inject a Logger into Parser instead of using wfDebug()

https://gerrit.wikimedia.org/r/519351

• kchapman moved this task from Inbox, needs triage to Doing (old) on the Performance-Team board.Jul 1 2019, 7:51 PM
• WDoranWMF added a project: Platform Team Workboards (Clinic Duty Team).Jul 18 2019, 2:13 PM
• WDoranWMF moved this task from Inbox to Later on the Platform Team Workboards (Clinic Duty Team) board.
• WDoranWMF moved this task from Later to External Code Review Needed on the Platform Team Workboards (Clinic Duty Team) board.Jul 18 2019, 4:29 PM
• WDoranWMF triaged this task as High priority.Jul 23 2019, 3:54 PM
• WDoranWMF moved this task from External Code Review Needed to External Code Review Completed on the Platform Team Workboards (Clinic Duty Team) board.Jul 24 2019, 5:26 PM
gerritbot added a comment.Jul 25 2019, 10:41 AM

Change 519351 merged by jenkins-bot:
[mediawiki/core@master] parser: inject a Logger into Parser instead of using wfDebug()

https://gerrit.wikimedia.org/r/519351

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.16; 2019-07-30).Jul 25 2019, 11:00 AM
gerritbot added a comment.Jul 26 2019, 7:01 AM

Change 519352 merged by jenkins-bot:
[mediawiki/core@master] parser: add speculative page IDs to use with {{PAGEID}}

https://gerrit.wikimedia.org/r/519352

Maintenance_bot removed a project: Patch-For-Review.Jul 26 2019, 7:10 AM
gerritbot added a comment.Jul 29 2019, 2:44 PM

Change 526157 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] parser: use 'vary-revision-sha1' in Parser::statelessFetchTemplate

https://gerrit.wikimedia.org/r/526157

gerritbot added a project: Patch-For-Review.Jul 29 2019, 2:44 PM
gerritbot added a comment.Aug 1 2019, 11:30 AM

Change 526964 had a related patch set uploaded (by Krinkle; owner: Aaron Schulz):
[mediawiki/core@master] Add missing title info in RenderedRevision::outputVariesOnRevisionMetaData()

https://gerrit.wikimedia.org/r/526964

gerritbot added a comment.Aug 1 2019, 5:40 PM

Change 526964 merged by jenkins-bot:
[mediawiki/core@master] Add missing title info in RenderedRevision::outputVariesOnRevisionMetaData()

https://gerrit.wikimedia.org/r/526964

ReleaseTaggerBot edited projects, added: MW-1.34-notes (1.34.0-wmf.17; 2019-08-06); removed: MW-1.34-notes (1.34.0-wmf.16; 2019-07-30).Aug 1 2019, 6:00 PM
Krinkle moved this task from Doing (old) to Blocked (old) on the Performance-Team board.Aug 6 2019, 1:10 AM
gerritbot added a comment.Aug 16 2019, 12:07 AM

Change 526157 merged by jenkins-bot:
[mediawiki/core@master] parser: use 'vary-revision-sha1' in Parser::statelessFetchTemplate

https://gerrit.wikimedia.org/r/526157

Maintenance_bot removed a project: Patch-For-Review.Aug 16 2019, 12:10 AM
aaron closed this task as Resolved.Aug 17 2019, 1:17 AM
ReleaseTaggerBot edited projects, added: MW-1.34-notes (1.34.0-wmf.20; 2019-08-27); removed: MW-1.34-notes (1.34.0-wmf.17; 2019-08-06).Aug 20 2019, 9:01 PM
aaron mentioned this in T225957: Investigate front end saving timing regression starting April 20, 2019.Aug 21 2019, 5:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits