Page MenuHomePhabricator

Closed button in Apex dialog misaligned, and primary button style not working
Closed, ResolvedPublic

Assigned To
Authored By
Esanders
Jun 28 2019, 11:04 AM
Referenced Files
F29662052: image.png
Jun 28 2019, 11:04 AM
F29662056: image.png
Jun 28 2019, 11:04 AM
Subscribers

Description

Before

image.png (162×523 px, 30 KB)

After
image.png (187×529 px, 9 KB)

  • The close button is too high positioned,
  • as the frameless primary button has no background in Apex, the buttons are left without visual separators.

Event Timeline

Change 519754 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] Apex theme: Fix icon position

https://gerrit.wikimedia.org/r/519754

Change 519754 merged by jenkins-bot:
[oojs/ui@master] Apex theme: Fix icon position

https://gerrit.wikimedia.org/r/519754

Volker_E claimed this task.
Volker_E moved this task from Backlog to OOUI-0.33.1 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.33.1); removed OOUI.

Change 520637 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.33.1

https://gerrit.wikimedia.org/r/520637

Change 520637 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.33.1

https://gerrit.wikimedia.org/r/520637