| Esanders | |
| Jun 28 2019, 11:22 AM |
| F29733025: image.png | |
| Jul 10 2019, 8:36 PM |
| F29678856: image.png | |
| Jul 3 2019, 7:12 PM |
| F29678854: image.png | |
| Jul 3 2019, 7:12 PM |
| F29673446: image.png | |
| Jul 1 2019, 1:32 PM |
| F29662091: image.png | |
| Jun 28 2019, 11:22 AM |
| F29662094: image.png | |
| Jun 28 2019, 11:22 AM |
Not every 'safe' action is marked as 'back' or 'closed' (which becomes icon only):
In these cases the frameless back button has almost the same treatment as the dialog title
Before:
If the intention was to drop support for labelled 'safe' actions then this should have been a breaking change, the API updated accordingly to force the user to use icons.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Volker_E | T226045 Improve process dialog appearance – simplify actions | |||
| Resolved | Volker_E | T226822 New dialog action design doesn't work well for labelled safe actions |
this should have been a breaking change
Well, it was a breaking release library change, but yes.
There was no audit of downstream usages, and consequently we have no plan for how to fix this. If there isn't a fix within a week it will have to be reverted.
There is also no separator when there are multiple secondary actions in the footer. I am concerned that we are now being forced to rush through fixes because of a quick merge, rather than taking the time to design for all cases properly.
Again, I don't see this to be any more “rush” than other changes, when we have realized necessary theme changes.
I will provide patches for the identified issues. In this case it's simple side borders/backgrounds around “safe” actions.
It was already possible to make frameless buttons primary, we didn't prevent OOUI implementors from doing just that. What we deal with now, is only realizing that there are shortcomings from my POV.
I will provide patches for the identified issues. In this case it's simple side borders/backgrounds around “safe” actions.
I'm not sure this makes it clear that the text on the left is a button, but the text on the right is a label.
Change 520349 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] WikimediaUI theme: Amend ProcessDialog ActionWidget appearance
Change 520349 merged by jenkins-bot:
[oojs/ui@master] WikimediaUI theme: Amend ProcessDialog ActionWidget appearance
Change 520637 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.33.1
If the action has a 'back' flag then it doesn't get the correct styling as it assumes the message will be converted to an icon, which it isn't on desktop (yet):
Change 521951 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] WMUI: Apply frameless dialog action hack to icon-only actions
Change 521951 merged by jenkins-bot:
[oojs/ui@master] WikimediaUI theme: Apply frameless appearance to icon-only dialog actions
Change 523823 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.33.3
