Deprecate Language::convertTitle(), findVariantLink(), updateConversionTable(), and friends
Open, Needs TriagePublic8 Estimated Story Points
Actions

Description

The Language class should not depend on the Title class. The only non-deprecated code that currently needs the Title class is code that delegates to LanguageConverter. Such methods in Title should be deprecated, callers should be changed to use LanguageConverter directly (or a more narrow interface derived from that class).

Note that Language will (for now) still need a LanguageConverter instance, but it should have no need to call any methods in LanguageConverter that need a Title object. Perhaps a new interface could be extracted that covers just the things that Language needs.

soft deprecation in 1.35
hard deprecation (also in 1.35 if we can remove all callers in time)

Details

Project	Branch	Lines +/-	Subject
mediawiki/core	master	+129 -62	Hard deprecation of Language::convertTitle(), ::findVariantLink(), ::updateConversionTable()
mediawiki/extensions/MobileFrontend	master	+12 -2	Use LanguageConverter::findVariantLink() instead of Language::findVariantLink()
mediawiki/extensions/ParserFunctions	master	+14 -1	Use LanguageConverter::findVariantLink() instead of Language::findVariantLink()
mediawiki/extensions/FileImporter	master	+7 -4	Use LanguageConverter::findVariantLink() instead of Language::findVariantLink()

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	Peter.ovchyn	T226832 Deprecate Language::convertTitle(), findVariantLink(), updateConversionTable(), and friends
Resolved	Peter.ovchyn	T226833 Introduce LanguageConverterFactory service
Resolved	Peter.ovchyn	T243306 Introduce shorthand to LanguageConverter for al SpecialPage hierarchy
Open	None	T243310 Once we have ContentHandlerFactory, we can think about injecting the LanguageConverterFactory into ContentHandler.
Resolved	Art-Baltai	T243560 Use ObjectFactory to construct ContentHandlers
Resolved	Peter.ovchyn	T243317 Create or define better approach to inject languageConverter into LinkHolderArray according to deprecation policy
Resolved	Peter.ovchyn	T243320 Inject a LanguageConverterFactory through ParserFactory into Parser
Resolved	Peter.ovchyn	T243321 Inject LanguageConverter via DI DefaultPreferencesFactory
Open	Peter.ovchyn	T243323 Inject LanguageConverter through constructor in SearchNearMatcher
Open	Peter.ovchyn	T243325 Avoid mutual dependency between LanguageConverter and Language by introducing specialised interfaces
Invalid	Peter.ovchyn	T252137 WIP: Introduce NamespaceNameLocalizer class
Invalid	Peter.ovchyn	T252151 WIP: Soft deprecate Language::getNamespaces and friends using global MediawikiServices
Open	None	T253325 Avoid using getNsIndex from UI / SpecialNewpages.php
Invalid	Peter.ovchyn	T253460 WIP: Replace Language related calls in LanguageConverter by injecting callbacks, and avoid LanguageConverter from Language
Open	Peter.ovchyn	T253834 Turn properties into protected Getters in LanguageConverter based hierarchy
Invalid	Peter.ovchyn	T253849 WIP: Factor convertNamespace and convertTitle methods out of LanguageConverter
Open	Peter.ovchyn	T253854 Inject tables into LanguageConverter in advance and avoid using loadTables function.
Open	Art.tsymbar	T254004 Use global LanguageConverterFacory as MediawikiService:: instead for injecting it via DI in Language class
Invalid	Peter.ovchyn	T254267 WIP: Replace LanguageConverter ::convertTitle and ::convertNamespace in favour of ConverterHelper's and deprecate
Open	Peter.ovchyn	T243326 Rename ILanguageInterface::convert function to eliminate ambiguity
Resolved	Peter.ovchyn	T243332 Create table with mapping between lang code and converter instead of using name convention
Resolved	Peter.ovchyn	T243760 Move Converter to respective files
Resolved	Peter.ovchyn	T243761 Add @group Language to all tests related to Language for easier navigation through tests

Event Timeline

daniel created this task.Jun 28 2019, 2:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 28 2019, 2:19 PM

daniel updated the task description. (Show Details)Jun 28 2019, 2:28 PM

WDoranWMF moved this task from Decoupling (CDP2) to mop on the Core Platform Team board.Jul 26 2019, 6:55 PM

WDoranWMF edited projects, added CPT Initiatives (Decoupling (CDP2)); removed Core Platform Team (Decoupling (CDP2)).

kchapman added a project: Core Platform Team Workboards (Contractor Workboard).Jan 24 2020, 5:48 PM

kchapman moved this task from Backlog to Estimated/Estimation on the Core Platform Team Workboards (Contractor Workboard) board.Jan 24 2020, 5:53 PM

Soft deprecation done in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/564789. Keeping the task open for hard deprecation.

daniel updated the task description. (Show Details)Feb 4 2020, 2:36 PM

daniel closed subtask T226833: Introduce LanguageConverterFactory service as Resolved.Feb 4 2020, 2:39 PM

WDoranWMF moved this task from Estimated/Estimation to Backlog on the Core Platform Team Workboards (Contractor Workboard) board.Mar 26 2020, 5:25 PM

Helga_sf moved this task from Backlog to Estimated/Estimation on the Core Platform Team Workboards (Contractor Workboard) board.Apr 30 2020, 11:08 AM

Helga_sf set the point value for this task to 8.Apr 30 2020, 2:41 PM

Art-Baltai claimed this task.May 5 2020, 11:00 PM

Art-Baltai moved this task from Estimated/Estimation to In Progress/Doing on the Core Platform Team Workboards (Contractor Workboard) board.

Change 594603 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai):
[mediawiki/core@master] Hard deprecation of Language::convertTitle(), ::findVariantLink(), ::updateConversionTable()

https://gerrit.wikimedia.org/r/594603

gerritbot added a project: Patch-For-Review.May 6 2020, 12:26 AM

Change 594604 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai):
[mediawiki/extensions/FileImporter@master] Use LanguageConverter::findVariantLink() instead of Language::findVariantLink()

https://gerrit.wikimedia.org/r/594604

Change 594605 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai):
[mediawiki/extensions/MobileFrontend@master] Use LanguageConverter::findVariantLink() instead of Language::findVariantLink()

https://gerrit.wikimedia.org/r/594605

Change 594606 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai):
[mediawiki/extensions/ParserFunctions@master] Use LanguageConverter::findVariantLink() instead of Language::findVariantLink()

https://gerrit.wikimedia.org/r/594606

Art-Baltai moved this task from In Progress/Doing to In Progress/In Review on the Core Platform Team Workboards (Contractor Workboard) board.May 6 2020, 2:17 PM

Change 594604 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Use LanguageConverter::findVariantLink() instead of Language::findVariantLink()

https://gerrit.wikimedia.org/r/594604

thiemowmde mentioned this in rEFLI030128897a84: Use LanguageConverter::findVariantLink() instead of Language::findVariantLink().May 6 2020, 3:29 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.32; 2020-05-12).May 6 2020, 4:00 PM

cscott added a subscriber: cscott.May 6 2020, 8:54 PM

Change 594605 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Use LanguageConverter::findVariantLink() instead of Language::findVariantLink()

https://gerrit.wikimedia.org/r/594605

Change 594606 merged by jenkins-bot:
[mediawiki/extensions/ParserFunctions@master] Use LanguageConverter::findVariantLink() instead of Language::findVariantLink()

https://gerrit.wikimedia.org/r/594606

ssastry mentioned this in T53587: Parsoid needs to run findVariantLink or some equivalent thing.May 11 2020, 8:43 PM

Matanya mentioned this in T253003: interwiki links disappered from side bar toolbox under 'in other languages' .May 18 2020, 11:25 AM

Helga_sf reassigned this task from Art-Baltai to Peter.ovchyn.Tue, Jun 23, 5:10 PM

Helga_sf added a subscriber: Art-Baltai.

Helga_sf removed a subscriber: Art-Baltai.