Page MenuHomePhabricator
Create Task
Maniphest T226832

Deprecate Language::convertTitle(), findVariantLink(), updateConversionTable(), and friends
Open, LowPublic8 Estimated Story Points
Actions

Description

The Language class should not depend on the Title class. The only non-deprecated code that currently needs the Title class is code that delegates to LanguageConverter. Such methods in Title should be deprecated, callers should be changed to use LanguageConverter directly (or a more narrow interface derived from that class).

Note that Language will (for now) still need a LanguageConverter instance, but it should have no need to call any methods in LanguageConverter that need a Title object. Perhaps a new interface could be extracted that covers just the things that Language needs.

  • soft deprecation in 1.35
  • hard deprecation (also in 1.35 if we can remove all callers in time)

See also T226834: In LanguageConverter, replace usages of Title with usages of LinkTarget

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+81 -39Hard deprecation of Language::convertTitle(), ::findVariantLink(), ::updateConversionTable()
mediawiki/extensions/MobileFrontendmaster+12 -2Use LanguageConverter::findVariantLink() instead of Language::findVariantLink()
mediawiki/extensions/ParserFunctionsmaster+14 -1Use LanguageConverter::findVariantLink() instead of Language::findVariantLink()
mediawiki/extensions/FileImportermaster+7 -4Use LanguageConverter::findVariantLink() instead of Language::findVariantLink()
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenPeter.ovchynT226832 Deprecate Language::convertTitle(), findVariantLink(), updateConversionTable(), and friends
 ResolvedPeter.ovchynT226833 Introduce LanguageConverterFactory service
 ResolvedPeter.ovchynT243306 Introduce shorthand to LanguageConverter for al SpecialPage hierarchy
 OpenNoneT243310 Once we have ContentHandlerFactory, we can think about injecting the LanguageConverterFactory into ContentHandler.
 ResolvedArt-BaltaiT243560 Use ObjectFactory to construct ContentHandlers
 ResolvedPeter.ovchynT243317 Create or define better approach to inject languageConverter into LinkHolderArray according to deprecation policy
 ResolvedPeter.ovchynT243320 Inject a LanguageConverterFactory through ParserFactory into Parser
 ResolvedPeter.ovchynT243321 Inject LanguageConverter via DI DefaultPreferencesFactory
 OpenNoneT243323 Inject LanguageConverter through constructor in SearchNearMatcher
 OpenPeter.ovchynT243325 Avoid mutual dependency between LanguageConverter and Language by introducing specialised interfaces
 InvalidPeter.ovchynT252137 WIP: Introduce NamespaceNameLocalizer class
InvalidPeter.ovchynT252151 WIP: Soft deprecate Language::getNamespaces and friends using global MediawikiServices
 OpenNoneT253325 Avoid using getNsIndex from UI / SpecialNewpages.php
 InvalidPeter.ovchynT253460 WIP: Replace Language related calls in LanguageConverter by injecting callbacks, and avoid LanguageConverter from Language
 OpenNoneT253834 Turn properties into protected Getters in LanguageConverter based hierarchy
 InvalidPeter.ovchynT253849 WIP: Factor convertNamespace and convertTitle methods out of LanguageConverter
 OpenNoneT253854 Inject tables into LanguageConverter in advance and avoid using loadTables function.
 OpenPeter.ovchynT254004 Use global LanguageConverterFacory as MediawikiService:: instead for injecting it via DI in Language class
 InvalidPeter.ovchynT254267 WIP: Replace LanguageConverter ::convertTitle and ::convertNamespace in favour of ConverterHelper's and deprecate
 OpenNoneT256976 Split NamespaceNames functionality into low-level data providing and high level logic.
 OpenNoneT243326 Rename ILanguageInterface::convert function to eliminate ambiguity
 ResolvedPeter.ovchynT243332 Create table with mapping between lang code and converter instead of using name convention
 ResolvedPeter.ovchynT243760 Move Converter to respective files
 ResolvedPeter.ovchynT243761 Add @group Language to all tests related to Language for easier navigation through tests

Event Timeline

daniel created this task.Jun 28 2019, 2:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 28 2019, 2:19 PM
daniel updated the task description. (Show Details)Jun 28 2019, 2:28 PM
WDoranWMF moved this task from Decoupling (CDP2) to mop on the Platform Engineering board.Jul 26 2019, 6:55 PM
WDoranWMF edited projects, added Platform Team Initiatives (Decoupling (CDP2)); removed Platform Engineering (Decoupling (CDP2)).
kchapman added a project: Platform Team Workboards (S&F Workboard).Jan 24 2020, 5:48 PM
kchapman moved this task from Backlog to Estimated/Estimation on the Platform Team Workboards (S&F Workboard) board.Jan 24 2020, 5:53 PM
daniel added a comment.Feb 4 2020, 2:35 PM

Soft deprecation done in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/564789. Keeping the task open for hard deprecation.

daniel updated the task description. (Show Details)Feb 4 2020, 2:36 PM
daniel closed subtask T226833: Introduce LanguageConverterFactory service as Resolved.Feb 4 2020, 2:39 PM
WDoranWMF moved this task from Estimated/Estimation to Backlog on the Platform Team Workboards (S&F Workboard) board.Mar 26 2020, 5:25 PM
Helga_sf moved this task from Backlog to Estimated/Estimation on the Platform Team Workboards (S&F Workboard) board.Apr 30 2020, 11:08 AM
Helga_sf set the point value for this task to 8.Apr 30 2020, 2:41 PM
Art-Baltai claimed this task.May 5 2020, 11:00 PM
Art-Baltai moved this task from Estimated/Estimation to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.
gerritbot added a comment.May 6 2020, 12:26 AM

Change 594603 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai):
[mediawiki/core@master] Hard deprecation of Language::convertTitle(), ::findVariantLink(), ::updateConversionTable()

https://gerrit.wikimedia.org/r/594603

gerritbot added a project: Patch-For-Review.May 6 2020, 12:26 AM
gerritbot added a comment.May 6 2020, 12:30 AM

Change 594604 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai):
[mediawiki/extensions/FileImporter@master] Use LanguageConverter::findVariantLink() instead of Language::findVariantLink()

https://gerrit.wikimedia.org/r/594604

gerritbot added a comment.May 6 2020, 12:38 AM

Change 594605 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai):
[mediawiki/extensions/MobileFrontend@master] Use LanguageConverter::findVariantLink() instead of Language::findVariantLink()

https://gerrit.wikimedia.org/r/594605

gerritbot added a comment.May 6 2020, 12:43 AM

Change 594606 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai):
[mediawiki/extensions/ParserFunctions@master] Use LanguageConverter::findVariantLink() instead of Language::findVariantLink()

https://gerrit.wikimedia.org/r/594606

Art-Baltai moved this task from In Progress/Doing to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.May 6 2020, 2:17 PM
gerritbot added a comment.May 6 2020, 3:28 PM

Change 594604 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Use LanguageConverter::findVariantLink() instead of Language::findVariantLink()

https://gerrit.wikimedia.org/r/594604

thiemowmde mentioned this in rEFLI030128897a84: Use LanguageConverter::findVariantLink() instead of Language::findVariantLink().May 6 2020, 3:29 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.32; 2020-05-12).May 6 2020, 4:00 PM
cscott added a subscriber: cscott.May 6 2020, 8:54 PM
gerritbot added a comment.May 7 2020, 3:41 AM

Change 594605 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Use LanguageConverter::findVariantLink() instead of Language::findVariantLink()

https://gerrit.wikimedia.org/r/594605

gerritbot added a comment.May 7 2020, 3:41 AM

Change 594606 merged by jenkins-bot:
[mediawiki/extensions/ParserFunctions@master] Use LanguageConverter::findVariantLink() instead of Language::findVariantLink()

https://gerrit.wikimedia.org/r/594606

ssastry mentioned this in T53587: Parsoid needs to run findVariantLink or some equivalent thing.May 11 2020, 8:43 PM
Matanya mentioned this in T253003: interwiki links disappered from side bar toolbox under 'in other languages' .May 18 2020, 11:25 AM
Helga_sf reassigned this task from Art-Baltai to Peter.ovchyn.Jun 23 2020, 5:10 PM
Helga_sf added a subscriber: Art-Baltai.
Helga_sf removed a subscriber: Art-Baltai.
Peter.ovchyn triaged this task as Low priority.Oct 20 2020, 10:35 AM
gerritbot added a comment.Oct 20 2020, 9:57 PM

Change 594603 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecation of Language::convertTitle(), ::findVariantLink(), ::updateConversionTable()

https://gerrit.wikimedia.org/r/594603

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Oct 20 2020, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 20 2020, 10:10 PM
Peter.ovchyn moved this task from In Progress/In Review to Backlog on the Platform Team Workboards (S&F Workboard) board.Oct 21 2020, 12:35 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL