In LanguageConverter, replace usages of Title with usages of LinkTarget
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	daniel
	Jun 28 2019, 2:27 PM

Project Tags

Referenced Files

None

Subscribers

Description

LanguageConverter is used a lot (via Language), so it should be as light weight as possible. Removing any dependency on Title would help with that. All present usages seem to only need functionality that could also be provided by a LinkTarget.

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Remove LanguageConverter dependencies on Title and use LinkTarget	Art-Baltai	mediawiki/core	master	+104 -46
	Remove LanguageConverter dependencies on Title and use LinkTarget	D3r1ck01	mediawiki/core	master	+52 -20

Customize query in gerrit

Related Objects

Mentioned In: T226832: Deprecate Language::convertTitle(), findVariantLink(), updateConversionTable(), and friends

Event Timeline

daniel created this task.Jun 28 2019, 2:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 28 2019, 2:27 PM

daniel mentioned this in T226832: Deprecate Language::convertTitle(), findVariantLink(), updateConversionTable(), and friends.Jun 28 2019, 2:28 PM

Change 524734 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/core@master] Remove LanguageConverter dependencies on Title and use LinkTarget

https://gerrit.wikimedia.org/r/524734

gerritbot added a project: Patch-For-Review.Jul 22 2019, 9:55 AM

xSavitar claimed this task.Jul 22 2019, 10:17 AM

Restricted Application added a project: User-xSavitar. · View Herald TranscriptJul 22 2019, 10:17 AM

xSavitar moved this task from Backlog to Under Review on the User-xSavitar board.Jul 22 2019, 10:17 AM

• WDoranWMF moved this task from Decoupling (CDP2) to mop on the Platform Engineering board.Jul 26 2019, 6:55 PM

• WDoranWMF edited projects, added: Core Platform Team Initiatives (Decoupling (CDP2)); removed: Platform Engineering (Decoupling (CDP2)).

• kchapman added a project: Platform Team Workboards (S&F Workboard).Jan 24 2020, 5:49 PM

• kchapman moved this task from Backlog to Estimated/Estimation on the Platform Team Workboards (S&F Workboard) board.Jan 24 2020, 5:53 PM

Art-Baltai moved this task from Estimated/Estimation to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.Jan 30 2020, 12:35 PM

Change 570296 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai):
[mediawiki/core@master] Remove LanguageConverter dependencies on Title and use LinkTarget

https://gerrit.wikimedia.org/r/570296

Art-Baltai moved this task from In Progress/Doing to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.Feb 5 2020, 11:49 AM

Art-Baltai added a project: Platform Engineering.

Peter.ovchyn reassigned this task from xSavitar to Art-Baltai.Feb 5 2020, 11:52 AM

Peter.ovchyn added a subscriber: xSavitar.

Peter.ovchyn subscribed.

xSavitar removed a project: User-xSavitar.Feb 7 2020, 10:11 AM

Change 524734 abandoned by D3r1ck01:
Remove LanguageConverter dependencies on Title and use LinkTarget

Reason:
Another patch is handling this

https://gerrit.wikimedia.org/r/524734

Change 570296 merged by jenkins-bot:
[mediawiki/core@master] Remove LanguageConverter dependencies on Title and use LinkTarget

https://gerrit.wikimedia.org/r/570296