Page MenuHomePhabricator
Create Task
Maniphest T226849

Hash all pageTokens or temporary identifiers from the EL Sanitization white-list as needed for iOS
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Hash temporary identifiers in app schemasanalytics/refinerymaster+4 -10
Hash tokens from the EL Sanitization white-list for iOS appanalytics/refinerymaster+20 -10
Customize query in gerrit

Related Objects
Search...

Event Timeline

kzimmerman created this task.Jun 28 2019, 6:54 PM
• fdans moved this task from Incoming to Radar on the Analytics board.Jul 1 2019, 3:51 PM
• chelsyx triaged this task as Medium priority.Jul 1 2019, 10:34 PM
• chelsyx moved this task from Triage to Doing on the Product-Analytics board.
gerritbot added a comment.Jul 1 2019, 10:35 PM

Change 520134 had a related patch set uploaded (by Chelsyx; owner: Chelsyx):
[analytics/refinery@master] Hash tokens from the EL Sanitization white-list for iOS app

https://gerrit.wikimedia.org/r/520134

gerritbot added a project: Patch-For-Review.Jul 1 2019, 10:35 PM
• chelsyx added a comment.Jul 1 2019, 10:41 PM

I hash the tokens for the following EL schemas used by the iOS app:

MobileWikiAppEdit
MobileWikiAppLogin
MobileWikiAppNavMenu
MobileWikiAppProtectedEditAttempt
MobileWikiAppSavedPages
MobileWikiAppShareAFact
MobileWikiAppToCInteraction

Please review. Thanks!

• chelsyx added a comment.Jul 11 2019, 6:58 PM

@mforns can you please review the patch? Thanks!

nshahquinn-wmf unsubscribed.Jul 12 2019, 9:52 AM
gerritbot added a comment.Jul 22 2019, 5:38 PM

Change 520134 merged by Nuria:
[analytics/refinery@master] Hash tokens from the EL Sanitization white-list for iOS app

https://gerrit.wikimedia.org/r/520134

Maintenance_bot removed a project: Patch-For-Review.Jul 22 2019, 6:11 PM
gerritbot added a comment.Jul 24 2019, 8:10 PM

Change 525280 had a related patch set uploaded (by Bearloga; owner: Bearloga):
[analytics/refinery@master] Hash temporary identifiers in app schemas

https://gerrit.wikimedia.org/r/525280

gerritbot added a project: Patch-For-Review.Jul 24 2019, 8:10 PM
gerritbot added a comment.Jul 31 2019, 1:45 PM

Change 525280 merged by Mforns:
[analytics/refinery@master] Hash temporary identifiers in app schemas

https://gerrit.wikimedia.org/r/525280

Maintenance_bot removed a project: Patch-For-Review.Jul 31 2019, 2:11 PM
Aklapper removed • chelsyx as the assignee of this task.Aug 12 2019, 12:06 AM
kzimmerman closed this task as Resolved.Sep 3 2019, 5:38 PM
kzimmerman claimed this task.

Looks like the patch was merged by @mforns (correct me if I'm wrong)

Aklapper edited projects, added Analytics-Radar; removed Analytics.Jun 10 2020, 6:44 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL