Page MenuHomePhabricator
Create Task
Maniphest T226911

Support running unit tests and extending MediaWikiUnitTestCase in skins and extensions
Closed, ResolvedPublic
Actions

Description

Plan is to:

  • Modify phpunit.xml.dist to support finding tests in extensions/**/tests/phpunit/unit
  • Add some code that runs before the testsuite to iterate over all extensions and skins, and call ExtensionRegistry::getInstance()->queue( $path ) followed by ExtensionRegistry::getInstance()->loadFromQueue()

Details

Related Gerrit Patches:
mediawiki/core : masterExtensionRegistry: Remove exportAutoloadClassesAndNamespaces
mediawiki/core : masterUnit tests: Remove duplicated code in ExtensionRegistry
mediawiki/core : masterUnit tests: Support unit tests in extensions and skins
mediawiki/extensions/Wikibase : masterMove trivial unit tests to the new structure
mediawiki/extensions/MobileFrontend : masterMigrate unit tests to the new structure

Related Objects
Search...

Event Timeline

kostajh created this task.Jun 30 2019, 12:58 AM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptJun 30 2019, 12:58 AM
Ladsgroup removed projects: MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Wikimedia-Hackathon-2019, Epic.Jun 30 2019, 1:05 PM
Ladsgroup awarded a token.

once this is done, I will apply it to wikibase.

kostajh added a comment.Jun 30 2019, 3:43 PM

Cool! I’ll try to post something later today.

gerritbot added a comment.Jun 30 2019, 5:58 PM

Change 519796 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/core@master] (wip) Unit tests: Support unit tests in extensions and skins

https://gerrit.wikimedia.org/r/519796

gerritbot added a comment.Jul 1 2019, 11:25 PM

Change 519796 merged by jenkins-bot:
[mediawiki/core@master] Unit tests: Support unit tests in extensions and skins

https://gerrit.wikimedia.org/r/519796

gerritbot added a comment.Jul 2 2019, 9:00 AM

Change 520193 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Move trivial unit tests to the new structure

https://gerrit.wikimedia.org/r/520193

gerritbot added a comment.Jul 2 2019, 11:29 AM

Change 520212 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/MobileFrontend@master] Migrate unit tests to the new structure

https://gerrit.wikimedia.org/r/520212

gerritbot added a comment.Jul 8 2019, 3:50 PM

Change 520212 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Migrate unit tests to the new structure

https://gerrit.wikimedia.org/r/520212

kostajh closed this task as Resolved.Jul 16 2019, 9:37 PM

Done via the patches above.

gerritbot added a comment.Aug 19 2019, 8:17 AM

Change 530809 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/core@master] Unit tests: Remove duplicated code in ExtensionRegistry

https://gerrit.wikimedia.org/r/530809

gerritbot added a comment.Aug 21 2019, 7:36 AM

Change 531352 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/core@master] ExtensionRegistry: Remove exportAutoloadClassesAndNamespaces

https://gerrit.wikimedia.org/r/531352

gerritbot added a comment.Sep 1 2019, 7:56 PM

Change 530809 merged by jenkins-bot:
[mediawiki/core@master] Unit tests: Remove duplicated code in ExtensionRegistry

https://gerrit.wikimedia.org/r/530809

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL