Support running unit tests and extending MediaWikiUnitTestCase in skins and extensions
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• kostajh
	Jun 30 2019, 12:58 AM

Description

Plan is to:

Modify phpunit.xml.dist to support finding tests in extensions/**/tests/phpunit/unit
Add some code that runs before the testsuite to iterate over all extensions and skins, and call ExtensionRegistry::getInstance()->queue( $path ) followed by ExtensionRegistry::getInstance()->loadFromQueue()

Details

Project	Branch	Lines +/-	Subject
mediawiki/extensions/Wikibase	master	+54 -103	Move trivial unit tests to the new structure
mediawiki/core	master	+20 -35	ExtensionRegistry: Remove exportAutoloadClassesAndNamespaces
mediawiki/core	master	+7 -14	Unit tests: Remove duplicated code in ExtensionRegistry
mediawiki/core	master	+52 -1	Unit tests: Support unit tests in extensions and skins
mediawiki/extensions/MobileFrontend	master	+57 -53	Migrate unit tests to the new structure

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T84948 MediaWiki core unit tests should be true unit tests (tracking)
Resolved	• kostajh	T89432 Make PHPUnit tests run without installing MediaWiki
Open	None	T87781 Split mediawiki tests into unit and integration tests
Resolved	• kostajh	T226911 Support running unit tests and extending MediaWikiUnitTestCase in skins and extensions

Event Timeline

• kostajh created this task.Jun 30 2019, 12:58 AM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptJun 30 2019, 12:58 AM

Mainframe98 added a subscriber: Mainframe98.Jun 30 2019, 5:30 AM

once this is done, I will apply it to wikibase.

Cool! I’ll try to post something later today.

Change 519796 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/core@master] (wip) Unit tests: Support unit tests in extensions and skins

https://gerrit.wikimedia.org/r/519796

gerritbot added a project: Patch-For-Review.Jun 30 2019, 5:58 PM

Michael awarded a token.Jul 1 2019, 8:10 AM

Change 519796 merged by jenkins-bot:
[mediawiki/core@master] Unit tests: Support unit tests in extensions and skins

https://gerrit.wikimedia.org/r/519796

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.13; 2019-07-09).Jul 2 2019, 12:00 AM

Change 520193 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Move trivial unit tests to the new structure

https://gerrit.wikimedia.org/r/520193

Change 520212 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/MobileFrontend@master] Migrate unit tests to the new structure

https://gerrit.wikimedia.org/r/520212

Change 520212 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Migrate unit tests to the new structure

https://gerrit.wikimedia.org/r/520212

Done via the patches above.

zeljkofilipin removed a subscriber: zeljkofilipin.Jul 17 2019, 10:00 AM

Change 530809 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/core@master] Unit tests: Remove duplicated code in ExtensionRegistry

https://gerrit.wikimedia.org/r/530809

Change 531352 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/core@master] ExtensionRegistry: Remove exportAutoloadClassesAndNamespaces

https://gerrit.wikimedia.org/r/531352

Change 530809 merged by jenkins-bot:
[mediawiki/core@master] Unit tests: Remove duplicated code in ExtensionRegistry

https://gerrit.wikimedia.org/r/530809

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.21; 2019-09-03); removed MW-1.34-notes (1.34.0-wmf.13; 2019-07-09).Sep 1 2019, 8:00 PM

Legoktm mentioned this in T240535: Clean up ExtensionRegistry autoloading mess.Dec 12 2019, 8:54 AM

Change 531352 abandoned by Kosta Harlan:
[mediawiki/core@master] ExtensionRegistry: Remove exportAutoloadClassesAndNamespaces

Reason:

https://gerrit.wikimedia.org/r/531352

Change 520193 abandoned by Ladsgroup:

[mediawiki/extensions/Wikibase@master] Move trivial unit tests to the new structure