Page MenuHomePhabricator

wikimedia_sites wrongly includes obsolete sites
Closed, ResolvedPublic

Description

closed_wikis where added to Family.langs property because Wikibase items may contain links to closed sites and the and newly implemented badges for sitelinks may fail due to closed wikis.

But wikimedia_sites wrongly includes obsolete sites because language_by_size property is a (mutable) list.

Family.langs class property takes the cls.codes and appends closed wikis to it. But cls.codes is a class property too which returns languages_by_size. Due to the fact that this is a mutable, appending closed wikis in Family.langs it just appends it to languages_by_size as an unwanted side effect.

Details

Related Changes in Gerrit:

Event Timeline

Change 516273 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [IMPR] make Family.langs property more robust

https://gerrit.wikimedia.org/r/516273

Change 516273 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] make Family.langs property more robust

https://gerrit.wikimedia.org/r/516273