Page MenuHomePhabricator

Termbox Beta SSR broken
Closed, ResolvedPublic

Description

The beta service is currently down, likely due to https://github.com/wikimedia/wikibase-termbox/blob/master/src/server/ServiceRunnerOptions.ts#L14 changing the config option to environment, which is not understood by service runner.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 1 2019, 10:59 AM
Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-19 board.

Change 520024 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Change ServiceRunnerOptions from environment back to config

https://gerrit.wikimedia.org/r/520024

Change 520024 merged by jenkins-bot:
[wikibase/termbox@master] Change ServiceRunnerOptions from environment back to config

https://gerrit.wikimedia.org/r/520024

We patched the underlying defect but found that environment variables that were expected to be optional (e.g. MESSAGES_CACHE_MAX_AGE) are mandatory ever since T225080 - this should also be addressed.

Change 520041 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[wikibase/termbox@master] infrastructure: fix service enviroment argument

https://gerrit.wikimedia.org/r/520041

Change 520041 merged by jenkins-bot:
[wikibase/termbox@master] infrastructure: fix service enviroment argument

https://gerrit.wikimedia.org/r/520041

SSR is working again, thanks @Pablo-WMDE for the follow-up! I created T227069 tracking the env var issues.

Tarrow closed this task as Resolved.Jul 15 2019, 8:37 AM