Page MenuHomePhabricator
Create Task
Maniphest T227031

Update wikibase-docker configuration for wdqs-frontend
Closed, ResolvedPublic
Actions

Description

Reported in wikibase telegram.

I cloned the wikibase-docker repository today and started it up with 'docker-compose -d'. I haven't added any properties or items yet, but when I go to the query service UI on port 8282 and run a query it returns data from Wikidata instead. Is it OK ask about things like this on this channel?

It sounds like the code for the wdqs front-end in terms of where or how things are configured has changed and the code in wikibase-docker doing thsi configuration needs updating.

Related Objects

Event Timeline

Addshore created this task.Jul 1 2019, 8:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 1 2019, 8:18 PM
Addshore triaged this task as High priority.Jul 1 2019, 8:18 PM
Addshore moved this task from incoming to consider for next sprint on the Wikidata board.
Addshore moved this task from Backlog to Bugs on the Wikibase-Docker-2017+ board.
Addshore added a project: Wikidata-Campsite.
Addshore moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.
Addshore mentioned this in T227032: Start tagging images of Query Service UI.Jul 1 2019, 8:24 PM
Andrawaag subscribed.Jul 1 2019, 9:09 PM

Yes, I replicated this issue on a Wikibase I was installing for a 2-minute demo for the upcoming Wikibase workshop in Ghent. The included wikibase query service is indeed returning results from Wikidata

jjkoehorst subscribed.Jul 2 2019, 11:03 AM

The issue identified was because the custom-config.json was not overwriting the settings stored in default-config.json. To overcome this a pull request was made that overwrites the default-config.json file upon startup.

See: https://github.com/wmde/wikibase-docker/pull/85

Lea_Lacroix_WMDE subscribed.Jul 2 2019, 11:05 AM
Andrawaag added a comment.Jul 2 2019, 11:28 AM

@jjkoehorst fix worked on my install: http://185.54.115.247:8282/#SELECT%20%2a%20WHERE%20%7B%0Awd%3AQ1%20%3Fp%20%3Fo%20.%0A%7D%20

• alaa_wmde edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.Jul 2 2019, 12:13 PM
• alaa_wmde moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Realworldobject subscribed.Jul 2 2019, 2:23 PM
hoo claimed this task.Jul 2 2019, 2:28 PM
hoo reassigned this task from hoo to Ladsgroup.Jul 2 2019, 2:46 PM
hoo subscribed.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJul 2 2019, 2:46 PM
Lucas_Werkmeister_WMDE subscribed.Jul 2 2019, 3:09 PM
In T227031#5299637, @jjkoehorst wrote:

The issue identified was because the custom-config.json was not overwriting the settings stored in default-config.json. To overcome this a pull request was made that overwrites the default-config.json file upon startup.

See: https://github.com/wmde/wikibase-docker/pull/85

If custom-config.json doesn’t override default-config.json, doesn’t that mean the query UI has to be fixed, rather than overriding default-config.json in Docker? The whole point of the separation was that default-config.json doesn’t have to be changed, after all.

Ladsgroup added a comment.Jul 3 2019, 10:57 AM

So I tested it locally and it doesn't query wikidata anymore but I also feel it's not reading the custom config at all either. Let me double check.

Ladsgroup added a comment.Jul 3 2019, 11:35 AM
In T227031#5300417, @Lucas_Werkmeister_WMDE wrote:
In T227031#5299637, @jjkoehorst wrote:

The issue identified was because the custom-config.json was not overwriting the settings stored in default-config.json. To overcome this a pull request was made that overwrites the default-config.json file upon startup.

See: https://github.com/wmde/wikibase-docker/pull/85

If custom-config.json doesn’t override default-config.json, doesn’t that mean the query UI has to be fixed, rather than overriding default-config.json in Docker? The whole point of the separation was that default-config.json doesn’t have to be changed, after all.

No, Let me explain in depth: WDQS GUI checks for existence of custom-config.json on its root directory (see wikibase/config.js) and overrides values of default-config.json if it finds them. The issue with the docker image was that it was put in the wrong directory (See PR and working directory) causing the config.json not to pick up the file. Now that's fixed. (I double checked everything)

Ladsgroup added a comment.Jul 3 2019, 11:36 AM
In T227031#5303193, @Ladsgroup wrote:

I also feel it's not reading the custom config at all either. Let me double check.

I have very misleading feelings, the configs are being picked up, the issue is there's a fatal in JS. I fix that now.

Ladsgroup moved this task from Doing to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 3 2019, 12:18 PM
In T227031#5303351, @Ladsgroup wrote:

the issue is there's a fatal in JS. I fix that now.

Unbelievable, AdBlock prevented loading UrlShortener.js and that caused fatals. With whitelisting localhost (!) it works like a charm. There's nothing to fix here.

Lucas_Werkmeister_WMDE added a comment.Jul 3 2019, 3:46 PM
In T227031#5303459, @Ladsgroup wrote:

Unbelievable, AdBlock prevented loading UrlShortener.js and that caused fatals. With whitelisting localhost (!) it works like a charm. There's nothing to fix here.

That would be T223068: Wikibase Query Service calls get flagged as tracker calls by some Firefox extensions.

• alaa_wmde moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 5 2019, 1:07 PM
• alaa_wmde subscribed.

Tested locally and verified it is working as expected

Lydia_Pintscher closed this task as Resolved.Jul 15 2019, 11:08 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits