Page MenuHomePhabricator
Create Task
Maniphest T227040

Dialog title is neither centered nor left-aligned on mobile
Closed, ResolvedPublic
Actions

Description

Dialog title is neither centered nor left-aligned on mobile. Previously it was centered, and now it's supposed to be left-aligned, but it's not. The placement seems to depend on the language.

For example, the link insert dialog from VE:

localhost_3080_w_index.php_title=Lorem_ipsum_dolor&mobileaction=toggle_view_mobile(iPhone 5_SE) (1).png (1×640 px, 64 KB)
localhost_3080_w_index.php_title=Lorem_ipsum_dolor&uselang=de(iPhone 5_SE) (2).png (1×640 px, 64 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update OOUI to v0.33.2mediawiki/coremaster+250 -104
Fix dialog title alignment on mobileoojs/uimaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Jul 1 2019, 9:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 1 2019, 9:55 PM
matmarex added a parent task: T226045: Improve process dialog appearance – simplify actions.Jul 1 2019, 9:55 PM
Esanders subscribed.Jul 3 2019, 7:14 PM

It looks like the centering code that adds inline padding styles to the title hasn't been disabled (or made desktop-only)

gerritbot added a comment.Jul 3 2019, 8:25 PM

Change 520525 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] Fix dialog title alignment on mobile

https://gerrit.wikimedia.org/r/520525

gerritbot added a project: Patch-For-Review.Jul 3 2019, 8:25 PM
gerritbot added a comment.Jul 3 2019, 9:30 PM

Change 520525 merged by jenkins-bot:
[oojs/ui@master] Fix dialog title alignment on mobile

https://gerrit.wikimedia.org/r/520525

Maintenance_bot removed a project: Patch-For-Review.Jul 3 2019, 10:10 PM
Volker_E closed this task as Resolved.Jul 9 2019, 10:02 PM
Volker_E assigned this task to Esanders.
Volker_E triaged this task as Medium priority.
Volker_E moved this task from Backlog to OOUI-0.33.2 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.33.2); removed OOUI.
gerritbot added a comment.Jul 10 2019, 2:13 PM

Change 521875 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.33.2

https://gerrit.wikimedia.org/r/521875

gerritbot added a project: Patch-For-Review.Jul 10 2019, 2:13 PM
gerritbot added a comment.Jul 10 2019, 3:28 PM

Change 521875 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.33.2

https://gerrit.wikimedia.org/r/521875

Maintenance_bot removed a project: Patch-For-Review.Jul 10 2019, 4:11 PM
Jdforrester-WMF added a project: MW-1.34-notes (1.34.0-wmf.14; 2019-07-16).Jul 10 2019, 5:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits