Page MenuHomePhabricator

Dialog title is neither centered nor left-aligned on mobile
Closed, ResolvedPublic

Description

Dialog title is neither centered nor left-aligned on mobile. Previously it was centered, and now it's supposed to be left-aligned, but it's not. The placement seems to depend on the language.

For example, the link insert dialog from VE:

Details

Related Gerrit Patches:
mediawiki/core : masterUpdate OOUI to v0.33.2
oojs/ui : masterFix dialog title alignment on mobile

Event Timeline

matmarex created this task.Jul 1 2019, 9:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 1 2019, 9:55 PM

It looks like the centering code that adds inline padding styles to the title hasn't been disabled (or made desktop-only)

Change 520525 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] Fix dialog title alignment on mobile

https://gerrit.wikimedia.org/r/520525

Change 520525 merged by jenkins-bot:
[oojs/ui@master] Fix dialog title alignment on mobile

https://gerrit.wikimedia.org/r/520525

Volker_E closed this task as Resolved.Jul 9 2019, 10:02 PM
Volker_E assigned this task to Esanders.
Volker_E triaged this task as Medium priority.
Volker_E moved this task from Backlog to OOUI-0.33.2 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.33.2); removed OOUI.

Change 521875 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.33.2

https://gerrit.wikimedia.org/r/521875

Change 521875 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.33.2

https://gerrit.wikimedia.org/r/521875