Page MenuHomePhabricator

HelpPanel search icon for RTL
Closed, InvalidPublic


    • The position of a question mark in HelpPanel
  • Should be flipped
  • The position should be different for RTL

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 3 2019, 12:24 AM

@Volker_E I have checked and it doesn't seem we have an RTL search icon in OOUI, shall we add one?

@Cntlsn Ha, nice catch @Etonkovidova. The issue here is not OOUI and it's search icon, but the false mirroring for the main search input.
The search icon has its handle to bottom left in RTL as well, as it resembles a real-world object where right handers are in majority, even in RTL languages. ;)
We can re-use this task for the main input.

Cntlsn added a comment.Jul 4 2019, 7:45 AM

@Volker_E good point! thanks for your input on this.

kostajh moved this task from Inbox to Q1 2019-20 on the Growth-Team board.Jul 18 2019, 12:01 AM

@Cntlsn @Volker_E can you please update the task description with what should happen for this task?

Thanks @kostajh. Considering what @Volker_E stated in the previous comment, maybe we should hear from @Dyolf77_WMF about what is the reason for the search icon in the main wiki search bar being mirrored?
That's just to try keeping consistency, as it was pointed out in the first place.

@Cntlsn that's really weird! The icon shouldn't be mirrored even for RTL search, but it's correct to put it in the end of the search line. Something more, I found that if you change in your preferences the default language to Arabic and visit any Wiki you will have the same icon mirrored in the search bar:

Cntlsn added a comment.EditedJul 18 2019, 3:06 PM

Thanks @Dyolf77_WMF for your input. You're right, that's happening on beta as well!
@kostajh I guess we would just move the icon to the right of the search bar in help panel, and I will open a new task about the issue with the mirrored icon.
Actually, the current SearchInputWidget on OOUI does feature the icon aligned to the left of the bar in LTR (and it correctly moves to the opposite side in RTL), is there a reason why we are using a different one?

Restricted Application added a project: I18n. · View Herald TranscriptJul 18 2019, 4:23 PM

This task should be declined. The real bug is tackled in T228435.

Cntlsn closed this task as Invalid.Jul 18 2019, 4:51 PM

Thanks @Volker_E. @kostajh @Etonkovidova in the screenshot above the rendering of the search bar is correct:

  • the icon is aligned to the right because it is at the beginning of the bar (not at the end like in the main search bar in the chrome area of the screen, where it is a button, not an indicator like in our scenario, see T228435#5346245)
  • the icon is not mirrored because it is correct that the handle is pointing bottom right also in RTL (see T227154#5304657 for full explanation)

I declare the task invalid.

Change 524291 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/Vector@master] Remove falesly introduced RTL version of 'search' icon