Page MenuHomePhabricator

SVG thumbnailing fails on windows due to symlink call
Closed, ResolvedPublic

Description

There is, as far as I can see, only one use of symlink in MediaWiki core. Symlinks are lightweight and ideal, but some systems may not allow them.

Instead of failing outright, an attempt should be made to copy the file and, only if that also fails, declare that the thumbnail creation has failed.

Event Timeline

Change 520347 had a related patch set uploaded (by markahershberger; owner: markahershberger):
[mediawiki/core@master] Use copy if symlink fails

https://gerrit.wikimedia.org/r/520347

Bawolff renamed this task from Use copy if symlink fails to SVG thumbnailing fails on windows due to symlink call.Apr 29 2022, 9:03 PM

Change 520347 merged by jenkins-bot:

[mediawiki/core@master] Use copy if symlink fails

https://gerrit.wikimedia.org/r/520347

TheDJ added a subscriber: TheDJ.

Considering this solved, but reopen if required