Page MenuHomePhabricator

Partial block notice is not shown when attempting to edit on mobile with a partial block
Closed, ResolvedPublic

Description

Steps to reproduce:

  • Create a partial page block against <user>
  • Try to edit the page from mobile, as <user>

Expected:

  • Block notice says: "You have been blocked from editing this page"

Actual:

  • Block notice says: "You have been blocked from editing <wiki>"

The problem is that 'blockedtext-partial' points to 'apierror-blocked' in ApiBase::blockMsgMap. It should point to 'apierror-blocked-partial'.

Details

Related Gerrit Patches:

Event Timeline

Tchanders created this task.Jul 3 2019, 6:59 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 3 2019, 6:59 AM

Change 520376 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/core@master] Fix API message maps for block errors

https://gerrit.wikimedia.org/r/520376

Change 520376 merged by jenkins-bot:
[mediawiki/core@master] Fix API message maps for block errors

https://gerrit.wikimedia.org/r/520376

dom_walden added a subscriber: dom_walden.

I have only been able to reproduce this when I:
a) am already on the edit page when my user is blocked, or
b) have unsaved edits

Otherwise, the block message appears (as a toast popup) as soon as I click the pen icon to edit the page.

@Tchanders Are there any other ways this is happening for you (if it matters)?

Nevertheless, the Expected behaviour now occurs for partial blocks.

It looks a bit different for a user's own talk page, but the API response is correct.


(User_talk showing the API response)

Bug does not appear to affect Special:CreateAccount, Special:EmailUser or Special:PasswordReset.

Niharika closed this task as Resolved.Jul 11 2019, 11:42 PM