Page MenuHomePhabricator
Create Task
Maniphest T227241

'Change label' and label preview in link context don't work after clicking on 1 or 2 character links
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (e2f4b0e96)mediawiki/extensions/VisualEditormaster+1 -1
ve.ui.AnnotationContextItem: Use ve.ce.Surface's logic for detecting annotationsVisualEditor/VisualEditormaster+28 -17
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Jul 4 2019, 12:13 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 4 2019, 12:13 AM
gerritbot added a comment.Jul 4 2019, 12:13 AM

Change 520127 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] ve.ui.AnnotationContextItem: Use ve.ce.Surface's logic for detecting annotations

https://gerrit.wikimedia.org/r/520127

gerritbot added a project: Patch-For-Review.Jul 4 2019, 12:13 AM
matmarex mentioned this in T225541: 'Change label' in link inspector broken when cursor is at end of link.Jul 4 2019, 12:16 AM
matmarex renamed this task from 'Change label' and label preview in link inspector doesn't work on single character links to 'Change label' and label preview in link context don't work on single character links.Jul 4 2019, 12:27 AM
matmarex updated the task description. (Show Details)
matmarex mentioned this in T226708: New mobile link context doesn't work on single character links.Jul 4 2019, 12:45 AM
matmarex added a subtask: T221967: Can't reliably gather list of annotation views from a DM offset.
matmarex added a project: VisualEditor-DataModel.Jul 4 2019, 12:48 AM
matmarex moved this task from Incoming to In progress on the VisualEditor (Current work) board.Jul 9 2019, 2:17 AM
Esanders renamed this task from 'Change label' and label preview in link context don't work on single character links to 'Change label' and label preview in link context don't work on 1 or 2 character links.Jul 18 2019, 10:11 AM
Esanders merged a task: T227673: Editing an existing link's label has no effect if label < 3 characters long.
Esanders updated the task description. (Show Details)
Esanders added subscribers: • ppelberg, JTannerWMF, Esanders.
Esanders renamed this task from 'Change label' and label preview in link context don't work on 1 or 2 character links to 'Change label' and label preview in link context don't work after clicking on 1 or 2 character links.Jul 18 2019, 10:24 AM
Esanders updated the task description. (Show Details)
gerritbot added a comment.Jul 18 2019, 10:24 AM

Change 520127 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ve.ui.AnnotationContextItem: Use ve.ce.Surface's logic for detecting annotations

https://gerrit.wikimedia.org/r/520127

Esanders moved this task from In progress to QA on the VisualEditor (Current work) board.Jul 18 2019, 10:24 AM

I'll file a separate task for cursoring onto a link, but that will mostly affect desktop which makes less use of change label.

Esanders removed a subtask: T221967: Can't reliably gather list of annotation views from a DM offset.Jul 18 2019, 10:27 AM
Esanders added a parent task: T221967: Can't reliably gather list of annotation views from a DM offset.
Maintenance_bot removed a project: Patch-For-Review.Jul 18 2019, 11:10 AM
gerritbot added a comment.Jul 19 2019, 4:10 PM

Change 524550 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e2f4b0e96)

https://gerrit.wikimedia.org/r/524550

gerritbot added a project: Patch-For-Review.Jul 19 2019, 4:10 PM
gerritbot added a comment.Jul 19 2019, 4:26 PM

Change 524550 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e2f4b0e96)

https://gerrit.wikimedia.org/r/524550

Maintenance_bot removed a project: Patch-For-Review.Jul 19 2019, 5:11 PM
JTannerWMF added a project: Editing QA.Jul 24 2019, 2:59 PM
matmarex moved this task from Inbox to High Priority on the Editing QA board.Aug 9 2019, 4:56 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.Aug 22 2019, 8:38 PM
Ryasmeen edited projects, added Verified; removed Editing QA.
• ppelberg closed this task as Resolved.Sep 3 2019, 1:50 AM
• ppelberg claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL