StatusValue should be thoroughly encapsulated
Open, MediumPublic
Actions

Assigned To

None

Authored By

	RazeSoldier
	Jul 4 2019, 8:34 AM

Description

Currently StatusValue has some member variables exposed externally, which destroys the encapsulation of this class.

$value
$success
$successCount
$failCount

We should access them via setter/getter.

Protect above several member variables, and coding the corresponding setter/getter.

Many things depend on these member variables and require a lot of compatibility work.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 4 2019, 8:34 AM

I hope the TC team can guide this task.

Tagging CPT instead of TechCom, since this is not cross-cutting.

For the record, we have public members in quite a few places. They feel a bit dirty, but are not necessarily a problem.

WDoranWMF triaged this task as Lowest priority.Jul 9 2019, 6:38 PM

WDoranWMF raised the priority of this task from Lowest to Needs Triage.

WDoranWMF triaged this task as Medium priority.

WDoranWMF moved this task from Inbox to Icebox on the Platform Engineering board.