Page MenuHomePhabricator

Dialog footers should be moved up on iOS when navigation menu isn't visible.
Closed, ResolvedPublic

Description

The bottom 44px of the screen is a secret click target for launching the navigation menu, so putting buttons in there will cause the user to have to click on them twice as the first click just opens the menu (https://benfrain.com/the-ios-safari-menu-bar-is-hostile-to-web-apps-discuss/)

We recently worked around this in VE by adding 44px bottom padding when the menu isn't visible: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/VisualEditor/+/516531/

Event Timeline

Esanders created this task.Jul 4 2019, 11:35 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 4 2019, 11:35 AM
matmarex edited projects, added OOUI (OOUI-0.33.3); removed OOUI.Jul 18 2019, 12:15 AM

As a side effect of T212159, the menu bar is now always visible while a (fullscreen) dialog is open, so this should be resolved.

Can this task be resolved? If not, please associate an active project / milestone with this task - thanks!

(If this did not get fixed in OOUI-0.33.3 then you may want to change the project tag to OOUI)

Aklapper edited projects, added OOUI; removed OOUI (OOUI-0.33.3).Mon, Sep 2, 7:46 AM

No reply to my previous comment in a month, hence adding OOUI.

matmarex closed this task as Resolved.Mon, Sep 2, 8:17 PM
matmarex edited projects, added OOUI (OOUI-0.33.3); removed OOUI.
matmarex added a subscriber: Volker_E.

I thought @Volker_E would want to close it, but it might as well be me.